Netanel Basal comments

Results 282 comments of


                                            Netanel Basal

Akita 7 fails in jest because we are missing type:module from package.json

I'm not sure. I didn't change anything. I think it is something with Jest.

Akita 7 fails in jest because we are missing type:module from package.json

We are not doing anything special. We're using Nx to build the package. Is there any issue in Nx regarding what you describe?

Linting libraries phase 1 - continued

Hi, I'm not sure what's the status here?

Linting libraries phase 1 - continued

Ok, I'll go over it later on. Thanks

Cannot find module 'bluebird'

![image](https://user-images.githubusercontent.com/6745730/143822243-d6265843-732d-4d8a-9d7f-95e954b3abbf.png)

Cannot find module 'bluebird'

I created a new Angular project.

Expose PaginatorPlugin.pagination in the public interface

You're getting it in the `selectPage` query: https://github.com/datorama/akita/blob/a7f1015aedb258c21b708d0a63e8cbd5ccb7bf21/libs/akita/src/lib/plugins/paginator/paginatorPlugin.ts#L323

EntityDirtyCheckPlugin is extremely slow in larger (>1000 entities) stores

You are welcome to submit a PR

fix(akita): restrict usage of sortByOrder to valid usages in type system

Thanks, we'll merge it in v7

Setting QuertyConfig on base query doesn't apply to UI or sub queries

The UI query points to a different store. You're welcome to create a PR that passes the query config to `createUIQuery`.