modulus icon indicating copy to clipboard operation
modulus copied to clipboard

🚀[FEA]: Add Kolmogorov - Arnold Networks for Modulus

Open androbomb opened this issue 1 year ago • 6 comments

Is this a new feature, an improvement, or a change to existing functionality?

New Feature

How would you describe the priority of this feature request

Low (would be nice)

Please provide a clear description of problem you would like to solve.

Due to its usefulness in Scientific Machine Learning, it would be relevant to add Kolmogorov - Arnold Network Layers in Modulus.

Describe any alternatives you have considered

No response

androbomb avatar May 13 '24 13:05 androbomb

I am interested to do this. Is there a process to plan for it? Or should one just go and come back with a PR that assumes the API design (choice of arguments, etc) they like?

PS. I see there is one available already: https://github.com/androbomb/kan-modulus

sohale avatar Jun 04 '24 19:06 sohale

Hi @androbomb, would you be interested in contributing your code here to Modulus? I'll be happy to work with you to get your PR merged.

mnabian avatar Oct 18 '24 00:10 mnabian

Hi @androbomb, would you be interested in contributing your code here to Modulus? I'll be happy to work with you to get your PR merged.

Dear @mnabian , I would love to. Let me know how to properly do it. Furthermore, I have started working on FastKAN implementation [see ArXiV paper], where instead of B-Splies, Jacobi/Chebyshev polinomials, a superposition of (learnable) Gaussian Kernels are used.

Nevertheless, I must stress that the pure PyTorch implementations I used in my github are adaptation of others users code, as reported in the code and in the Readme.md:

Let me know how to proceed. Have a nice day

androbomb avatar Oct 18 '24 08:10 androbomb

Hi @androbomb, would you be interested in contributing your code here to Modulus? I'll be happy to work with you to get your PR merged.

Dear @mnabian , I updated my GitHub folder adding the code for FastKAN (KAN with Radial Basis Function instead of B-splines).

In that repository I have created Modulus SYM models (not plain Modulus). Should I create a PR for Modulus SYM? If so, can I add you to the fork as Maintainer to help me creating the PR?

Best regards

androbomb avatar Oct 21 '24 10:10 androbomb

Hi @androbomb, sorry I missed this thread. Yes please go ahead and open a PR. Feel free to add me as maintainer to your fork.

mnabian avatar Jan 14 '25 17:01 mnabian