datetime Data init, and combination with Query objects

Open davidhassell opened this issue 3 years ago • 3 comments

Hi Sadie, bit rambling, but fixes a bug that didn't allow Data objects to be instantiated from datetime objects, and also one that prevented constructs from being combined with Query objects, in some circumstances (the latter uncovered the former).

Aug 26 '22 10:08 davidhassell

... hold on, might have found a third bug that can be fixed here ...

Aug 26 '22 11:08 davidhassell

The thrid bug was actually https://github.com/NCAS-CMS/cfdm/pull/212 in cfdm, now merged so good to go, here (Needs the cfdm fix for the new tests to work)

Aug 26 '22 15:08 davidhassell

now merged so good to go, here

Nice. In that case I'll set to 'Ready for review' (which somehow I get the option of doing, not just yourself as PR author!) just so I can track this without assuming it's not ready...

Aug 26 '22 16:08 sadielbartholomew