MMGIS icon indicating copy to clipboard operation
MMGIS copied to clipboard

Configuration REST API - Mission Bugs

Open Outridair opened this issue 2 years ago • 1 comments

  • Sometimes saving the mission config will default the name to "Earth" if nothing else is provided.
  • Renaming Mission in the mission config doesn't seem to do anything.
  • Mission Version is not optional as indicated in the documentation
  • Mission Upsert always creates a new record/version regardless of what version number you give it. (I would expect it to update its current version)
  • Update Mission doesnt check for valid json as far as I could tell.

Outridair avatar Feb 16 '23 22:02 Outridair

  1. There's nowhere in the code that defaults a name to "Earth".
  2. In the /upsert body, config.msv.mission is required and generally should remain the same as the top level mission (it's disabled in the Initial Tab but still can be changed programmatically here). Changing it would change the MMGIS page name as well as point to a different path in Missions/{mission} in case you're using an local/relative-to-Missions-folder paths in the configuration.
  3. See #329
  4. This is intended. Passing {mission: "string", config: {}} to /upsert will bump to the next available version number with the contents of config. Passing {mission: "string", version: number} will bump to the next available version number with the contents of the mission's previous configuration object versioned version.
  5. It's true that the configuration validator is not complete. Most, if not all, of its validations happen for the layers.

tariqksoliman avatar Feb 23 '23 00:02 tariqksoliman