sui

sui copied to clipboard

Can we also update https://github.com/MystenLabs/sui/blob/21c26ce6a5d4e3448abd74323e3164286d3deba6/sdk/typescript/src/types/common.ts#L23 ?

Nov 24 '22 01:11 666lcz

Can we also update

https://github.com/MystenLabs/sui/blob/21c26ce6a5d4e3448abd74323e3164286d3deba6/sdk/typescript/src/types/common.ts#L23

?

thanks for catching, added and fixed unit tests. there is no e2e search test for tx digest thats why nothing fails on ci. just added a e2e test for that

Nov 25 '22 16:11 joyqvq

💳 Wallet Extension has been built, you can download the packaged extension here: https://github.com/MystenLabs/sui/actions/runs/3593754579#artifacts

Nov 25 '22 16:11 github-actions[bot]

Thanks for pinging me @kchalkias! Is the change only for tx digest (and not object digest)? If so, then we’re good. If it affects object digest then we’ll need changes in the bcs implementation as well.

Nov 29 '22 10:11 damirka

Thanks for pinging me @kchalkias! Is the change only for tx digest (and not object digest)? If so, then we’re good. If it affects object digest then we’ll need changes in the bcs implementation as well.

correct not object digest. although it should not impact bcs regardless, since bcs is concerning struct -> bytes not bytes -> string, base58 would only affect the latter.

Nov 29 '22 15:11 joyqvq

Looks like there's some build error to fix - otherwise looks great to me! Thanks for adding the tests!

Nov 30 '22 19:11 666lcz