sui

sui copied to clipboard

I've written a bunch of comments about consistency requirements in authority_store.rs as an effort to understand this code better. Please let me know what I've gotten wrong.

Thanks for the comments all.

A lot of the discussion centers around whether we need read-after-write or eventual consistency for various tables. I was doing my best to document what level of consistency has been assumed by other parts of the system today as implemented, whereas @gdanezis has pointed out many places where we could use eventual consistency if other parts of the system were modified to tolerate it.

I'm not sure code comments are the right place to document the sui-protocol-level requirements that George is highlighting, since relaxing any specific storage components to eventual consistency would likely require far-reaching changes to other parts of the system. I think such requirements probably belong in the sui whitepaper.

I'm not sure code comments are the right place to document the sui-protocol-level requirements that George is highlighting, since relaxing any specific storage components to eventual consistency would likely require far-reaching changes to other parts of the system. I think such requirements probably belong in the sui whitepaper.

I agree code comments should document what is needed right now. And design docs what could be done in the future. HOWEVER, code comments can claim weaker guarantees to avoid users of facilities taking a dependency on stronger guarantees.