sui icon indicating copy to clipboard operation
sui copied to clipboard

[wallet] fix can not see all coins when bottom nav is on

Open ntsd opened this issue 2 years ago • 1 comments

  • fix can not see all coins when the bottom nav is on by changing extra space for nav from padding-bottom to margin-bottom

Description

Before, the last coin is underlaid at the bottom of the nav.

Screenshot 2023-04-26 173806

After, now we can see all.

Screenshot 2023-04-26 173556

Test Plan

How did you test the new or updated feature? check on the view.


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • [ x ] user-visible impact
  • [ ] breaking change for a client SDKs
  • [ ] breaking change for FNs (FN binary must upgrade)
  • [ ] breaking change for validators or node operators (must upgrade binaries)
  • [ ] breaking change for on-chain data layout
  • [ ] necessitate either a data wipe or data migration

Release notes

  • fix can not see all coins when the bottom nav is on

ntsd avatar Apr 26 '23 10:04 ntsd

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Apr 26, 2023 10:50am
explorer-storybook ⬜️ Ignored (Inspect) Apr 26, 2023 10:50am
sui-wallet-kit ⬜️ Ignored (Inspect) Apr 26, 2023 10:50am
wallet-adapter ⬜️ Ignored (Inspect) Apr 26, 2023 10:50am

vercel[bot] avatar Apr 26 '23 10:04 vercel[bot]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jun 26 '23 02:06 github-actions[bot]

Close already fixed by other commit

ntsd avatar Sep 08 '23 23:09 ntsd