sui icon indicating copy to clipboard operation
sui copied to clipboard

[framework] Kiosk, TransferPolicy: post-audit fixes

Open damirka opened this issue 2 years ago • 2 comments

Description

  • adds check that item exists on list and list_with_purchase_cap
  • fixes broken behavior for policy::remove_rule
  • adds kiosk::uid function to read UID if allow_extensions set to true
  • adds transfer_policy::rules function to read assigned "Rules"
  • adds kiosk::ItemPurchased event

Test Plan

Includes tests for new behaviors, makes sure that the fixes work.

Type of Change (Check all that apply)

  • [x] user-visible impact
  • [ ] breaking change for a client SDKs
  • [ ] breaking change for FNs (FN binary must upgrade)
  • [ ] breaking change for validators or node operators (must upgrade binaries)
  • [ ] breaking change for on-chain data layout
  • [ ] necessitate either a data wipe or data migration

Release notes

  • adds check that item exists on list and list_with_purchase_cap
  • fixes broken behavior for policy::remove_rule
  • adds kiosk::uid function to read UID if allow_extensions set to true
  • adds transfer_policy::rules function to read assigned "Rules"
  • adds kiosk::ItemPurchased event

damirka avatar Apr 21 '23 13:04 damirka

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Apr 24, 2023 11:58am
explorer-storybook ⬜️ Ignored (Inspect) Apr 24, 2023 11:58am
sui-wallet-kit ⬜️ Ignored (Inspect) Apr 24, 2023 11:58am
wallet-adapter ⬜️ Ignored (Inspect) Apr 24, 2023 11:58am

vercel[bot] avatar Apr 21 '23 13:04 vercel[bot]

@sblackshear @amnn re-requesting review after adding an event ItemPurchased and a getter for TransferPolicy.rules field.

damirka avatar Apr 23 '23 19:04 damirka