Multiverse-Inventories icon indicating copy to clipboard operation
Multiverse-Inventories copied to clipboard

Incompatibility with Super Vanish

Open slvlr opened this issue 4 years ago • 7 comments

  1. When linking files, do not attach them to the post! Copy and paste any logs into https://gist.github.com/ or other similar service.

Information

  • Server version: This server is running Paper version git-Paper-249 (MC: 1.17.1) (Implementing API version 1.17.1-R0.1-SNAPSHOT) (Git: 6fa1983) You are running the latest version Previous version: git-Paper-239 (MC: 1.17.1)

  • Full output of /mv version -p: <https://paste.gg/p/anonymous/ab96bf3efb59432483232603f745f07e

Help request

Problem Multiverse inventories has a compatibility issue with Super Vanish https://www.spigotmc.org/resources/supervanish-be-invisible.1331/ If you try to open a chest in vanish, it switches your gamemode to spectator to be able to open the chest. if MV inventories is installed. Your inventory will flash but not change, and then close the container opened immediately. The Dev of Super Vanish doesn't think he can fix this. Is this something that you would be a able to add compatibility for?

What I have tried Uninstalling Multiverse inventories. Supervanish worked fine.

slvlr avatar Sep 04 '21 16:09 slvlr

The developer of SuperVanish can most likely fix this by cancelling the GameModeChangeShareHandlingEvent when needed.

nicegamer7 avatar Sep 26 '21 23:09 nicegamer7

Maybeee this https://github.com/Multiverse/Multiverse-Inventories/pull/459 will help?

benwoo1110 avatar Sep 27 '21 03:09 benwoo1110

The developer of SuperVanish can most likely fix this by cancelling the GameModeChangeShareHandlingEvent when needed.

The SV dev says the way silent open chest works is that it temporarily puts you into spectator mode so the server doesn't send the opening sound an animation. If you have separate inventories for spectator mode then that causes issues. It's already such a messy solution though, if I mess with the GameModeChangeShareHandlingEvent as well it would probably cause more issues than it solves. Is there no option to exempt spectator mode from having separate inventories - if not can this be added?

slvlr avatar Sep 27 '21 10:09 slvlr

Test with: Multiverse-Inventories-4.2.3-SNAPSHOT.zip

What have you changed in this build. Have you changed it so spectator has a separate inventory, or attempted to fix my issue another way?

slvlr avatar Sep 27 '21 11:09 slvlr

Basically #459: dont do inv change if changing to spectator mode since spectator mode shouldn't have inv anyways. I dont have time to go into code details rn.

benwoo1110 avatar Sep 27 '21 11:09 benwoo1110

I believe ben's solution is better than the one I came up with.

nicegamer7 avatar Sep 27 '21 16:09 nicegamer7