FuzzManager icon indicating copy to clipboard operation
FuzzManager copied to clipboard

Show all signature matches when trying to bucket a crash.

Open jschwartzentruber opened this issue 5 years ago • 2 comments

Searching for matching buckets for an unbucketed crash only shows "good" matches, where "good" is fairly arbitrary. Instead show all matches (ordered by quality of the match), and let the user decide.

jschwartzentruber avatar Feb 04 '20 20:02 jschwartzentruber

Codecov Report

Merging #593 into master will decrease coverage by <.01%. The diff coverage is 5.4%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #593      +/-   ##
==========================================
- Coverage   66.02%   66.01%   -0.01%     
==========================================
  Files          80       80              
  Lines        7976     7975       -1     
==========================================
- Hits         5266     5265       -1     
  Misses       2710     2710
Impacted Files Coverage Δ
server/crashmanager/views.py 65.11% <5.4%> (-0.05%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a2d82bf...efd2c59. Read the comment docs.

codecov[bot] avatar Feb 04 '20 20:02 codecov[bot]

@choller pointed out that this was a necessary optimization because for many signatures, searching all buckets would be unacceptably slow.

needs further thought to see if both goals can be achieved. (performant and showing more matches)

jschwartzentruber avatar Jun 10 '20 14:06 jschwartzentruber