gimbal icon indicating copy to clipboard operation
gimbal copied to clipboard

updating step 3 config file usage

Open bronz3beard opened this issue 6 years ago • 3 comments

resolves #160

ReadMe.md update This step is added for clarity on being able to use the config file

Pull request checklist

Please check if your PR fulfills the following requirements:

  • [X] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Pull request type

Docs update

Please check the type of change your PR introduces:

  • [X] Documentation content changes

Does this introduce a breaking change?

  • [ ] Yes
  • [X] No

Other information

None

bronz3beard avatar Oct 18 '19 07:10 bronz3beard

This shouldn't be needed as here in the code, we look for the config file. The glob that is used is .gimbalrc.{js,json,yaml,yml} and it's using the cwd which defaults to process.cwd() (where you executed the command at). Instead of updating the docs, the bug would need to be found and fixed instead.

mitchellsimoens avatar Oct 18 '19 12:10 mitchellsimoens

@mitchellsimoens Do you know if there is a way I can use the same approach re --config ./filelocation in the github action? I know this is not the desired approach but I would really like to show the usage for gimbal on our GH PRs to the team. Just as a temp fix? If not all good I just wanted to ask. 😃

bronz3beard avatar Nov 03 '19 23:11 bronz3beard

@bronz3beard the entrypoint of the gimbal action is gimbal which means you can use a step's with to add additional args: https://help.github.com/en/github/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions#jobsjob_idstepswith

mitchellsimoens avatar Nov 04 '19 14:11 mitchellsimoens