Mike Stall
Mike Stall
These are needed to assist in invoking lamba parameters. But the LambdaFormulaValue present in the arguments already closes over these - so can we remove these from the info and...
Current nugets are v1. Here are API breaking changes to consider for a v2 nuget. _No change to language semantics here_ - just API breaking to take advantage of lessons...
Join() should warn if predicate doesn't use both LeftRecord and RightRecord. This would flag cases like this, which could produce surprising results: `Join(Sequence(3), Sequence(3), LeftRecord.Value in [1,2], JoinType.Left, RightRecord.Value As...
Some improvements to: https://github.com/microsoft/Power-Fx/blob/main/src/libraries/Microsoft.PowerFx.Core/Entities/External/TableDelegationInfo.cs This describes what abilities a RecordType can delegate. Principles: 1. **Specify what's allowed; not what's restricted**. Delegation needs to know exactly what is happening, and so...
Join shouldn't use DValue or RecordValue as a dictionary key. https://github.com/microsoft/Power-Fx/blob/cce6c4b1a70bf4aa54ba841fef249900b8515519/src/libraries/Microsoft.PowerFx.Interpreter/Functions/LibraryTable.cs#L584 Fx does not have language semantics for RecordValue comparison. Thing 1: Join / Summarize / Distinct all have this...
No change to language semantics , but consider some implementation improvements to help with maintainability & delegation. **[1] Comment the implementation** **[2] In Summarize, line 1446, we do a uniqueness...
HttpClient already provides the base address. So we shouldn't also need uriPrefix (which is conceptually just part of the base address). An additional benefit is that this lets the host...
If the underlying NL network call fails (due to 429, 500, 400 or whatever - the reason doesn't matter here ) - 1. what should Power Apps do? At the...
This is a flakey test. , failing here https://github.com/microsoft/Power-Fx/pull/2728/checks?check_run_id=33611576122 Anything with something like this CancelAfter(500) ms is going to be flaky. https://github.com/microsoft/Power-Fx/blob/ef55044c27a772f77eb6343b867facfdd59dc944/src/tests/Microsoft.PowerFx.Interpreter.Tests.Shared/LanguageServiceProtocol/RedesignedLanguageServerTests/CancellationTests.cs#L31 Make it deterministic.