MicheleBertoli
v2.0 :tada: :tada: :tada:
Awesome stuff, well done @AnatoleLucet I left a few comments, please let me know if they make sense
I also have a couple of questions:
- could you please add the instructions to install/run the package and the examples?
- I see that there's no tests right now, may I ask what's the plan?
Thanks for taking the time to review this whole pr :pray:
could you please add the instructions to install/run the package and the examples?
Yes, I'm planning on writing the doc in the readme and make a contributing.md file.
I see that there's no tests right now, may I ask what's the plan?
I was planning on writing tests cases mainly for the lib/ folder and maybe a few for components/ and hooks/.
Since components/ and hooks/ are tightly coupled with google-maps, it might be a bit complicated to write complete tests suits for them. I'll see what's possible, but if you have any advice, I'm more than interested!
I started working on the docs. Feels like it's taking more time to write the docs than the lib :smile: You can see the rendered version here
Still need to write the documentation for the hooks and animations
JUST ADDED MORE FEATURES REGARDING ANIMATION (MAINLY GROWING/SHRINKING POLYGONS WHEN THEY APPEAR/DISAPPEAR), TESTS FOR THE lib/ FOLDER, ESLINT AND A CI.
I'LL ADD MORE TESTS FOR COMPONENTS AND HOOKS, AND FINISH WRITING THE DOC IN THE NEXT COUPLE DAYS. BUT NOT RIGHT NOW... BECAUSE MY CAPS LOCK IS STUCK FOR THE REST OF THE DAY.
CHEERS, AND HAPPY CAPS LOCK DAY! :tada:
WOW - you are on fire, @AnatoleLucet Amazing job adding docs and tests
I agree it's tricky to test components that depend on google-maps (I was patching window.google before)
maybe e2e / screenshot tests could help?
Thanks once again for the amazing progress I hope your keyboard is OK now : )))
Please let me know if there's any specific part that might benefit from an additional review
I spent quite some time to try and setup visual regression tests but had troubles with https://github.com/jsdom/jsdom/pull/3489 and https://github.com/vitest-dev/vitest/issues/3756 (no more luck with Jest). I might put this on hold until https://github.com/vitest-dev/vitest/issues/3756 is resolved.
But the good news is, I just pushed what was left to document!
@MicheleBertoli let me know how you want to proceed. IMO this PR is ready to be merged (event though there are no tests for components and hooks) and be released as a next/rc version to get a few feedbacks.
Hello @AnatoleLucet, and thanks once again for the outstanding work on the v2. I love the simplicity and intuitiveness of the API, the docs, and the examples so much :)
I spent some time reviewing the PR and left a few comments - please let me know if they make sense.
Happy to merge and ship under next (and explore a testing strategy in parallel).
It seems there's a little formatting issue on examples/basic/pnpm-lock.yaml
Do we want to fix it before merging? (just to get all the lights green :))
Thanks once again for the excellent work, feel free to merge into master in your own time.
FYI I'm playing around with Cypress (running the marker example and checking that the marker is there)
Hey @MicheleBertoli Amazing! Thanks for releasing the new version! :tada: :tada:
I fixed the CI and pushed a few small changes. I think you need to approve the PR for me to be able to merge it, but feel free to merge!
@AnatoleLucet, sorry for putting this back in your queue.
However, as I was working on e2e tests, I noticed that events don't seem to be working.
Repro: add onClick={() => console.log("clicked")} to GMapsMarker in marker example.
From a quick look, it seems the issue is that the hook that adds the event listeners only runs on updates. In fact, it works when the component re-renders.
I hope this makes sense, and happy to provide more context if valuable.
Interesting. Good thing we're going to have test cases for this then :sweat_smile: Thanks for the feedback, i'll check as soon as possible :pray: