Micha Reiser

[red-knot] Rename `FileSystem` to `System`

11

## Summary This PR is mainly a renaming PR to address the confusion around the existing `FileSystem` trait. Today, Red Knot uses a `FileSystem` trait to abstract the system-dependent file-level...

[red-knot] Prevent salsa cancellation from aborting the program

1

## Summary This PR wraps the public-visible `Program` methods to use `Cancelled::catch` to prevent that any salsa cancellation tears down its thread. I honestly don't think this change is safe...

## Summary I tried in this PR to upgrade annotation snippet but I hit a blocker because annotation snippet has now become more opinionated. It now prefixes every message with...

The program currently panics when Salsa cancels a pending query. I [reached out in the Salsa zulip](https://salsa.zulipchat.com/#narrow/stream/145099-general/topic/How.20to.20use.20.60Cancelled.3A.3Acatch.60) to learn out how to use Cancelled::catch correctly. From https://github.com/astral-sh/ruff/pull/11972

https://github.com/astral-sh/ruff/pull/12010 (shipped in Ruff 0.5) made using `output-format=text` a hard error. The next deprecation step is to remove the option entirely in 0.6 or 0.7

Formatter: `string_processing` preview style

6

Add support for Black's improved [string processing](https://black.readthedocs.io/en/stable/the_black_code_style/future_style.html#improved-string-processing). > Black will split long string literals and merge short ones. Parentheses are used where appropriate. When split, parts of f-strings that don’t...

https://github.com/astral-sh/ruff/pull/12006 made using `tab-size` a hard error (Ruff 0.5). We should remove the option in a future minor release (0.6 or 0.7?)

The `ASYNC1xx` rules used to be `trio` specific rules, but the upstream `flake8-async` rules now also cover `asyncio` and `anyio` (see https://github.com/astral-sh/ruff/pull/10416 for when we recoded the `trio` rules to...

f-string formatting: Consider format specs when choosing the preferred quotes

3

The new preview style formats ```python "" f'{1:""}' ``` as ```python f"{1:\"\"}" ``` This is correct but results in unnecessary escapes. I think we should account for the quotes in...

Disallow single-line implicit concatenated strings

1

## Summary I mainly put this up because I'm curious about the ecosystem changes. A proper implementation has to take the result of `FormatImplicitConcatenatedFlat::new` into account instead of using the...