meteor-simple-schema icon indicating copy to clipboard operation
meteor-simple-schema copied to clipboard

Meteor 3.0 compatibility

Open jankapunkt opened this issue 1 year ago • 10 comments

This is now the updated migration base-branch, exceeding #740 / #738 This means all of the following tasks should be done in an own PR, pointing to this one's branch (migrate/3.0)

jankapunkt avatar Dec 21 '23 09:12 jankapunkt

I come to the point to realize there is no way to support both sync and async computations. Since any method call will require async this bubbles down to all functions involved in the validation chain.

It's also nearly impossible to break up the existing syn structures and make them partially async using conditional return of Promises, where applicable.

It works for the labels but it does not work at all for doValidation which is basically the core validation routine, without making it all async.

I therefore will go down the path of making it fully async. Any objections please add here.

jankapunkt avatar Feb 07 '24 12:02 jankapunkt

published 2.0.0-rc300.0 → compatibility with 3.0-rc.2

jankapunkt avatar Jun 11 '24 09:06 jankapunkt

Hi @jankapunkt , is 2.0.0-rc300.0 already supporting async functions for autoValue ? It doesn't seem to work in my setup. Thanks !

vparpoil avatar Jun 24 '24 12:06 vparpoil

Published aldeed:[email protected] which should allow for final Meteor 3 compatibility.

StorytellerCZ avatar Jul 16 '24 07:07 StorytellerCZ

@jankapunkt for lint fixes I would be willing to move to Biome and standardize that across the entire organization. Thoughts?

StorytellerCZ avatar Jul 16 '24 12:07 StorytellerCZ

@vparpoil no, async validate etc. is a much bigger effort than expected. For now we will only cover Meteor 3.0 compatibility (in terms of versions / dependencies) and tackle full async in another PR

jankapunkt avatar Jul 16 '24 12:07 jankapunkt

@StorytellerCZ let's discuss biome in the organization repo / discussions there

jankapunkt avatar Jul 16 '24 12:07 jankapunkt

I come to the point to realize there is no way to support both sync and async computations. Since any method call will require async this bubbles down to all functions involved in the validation chain.

It's also nearly impossible to break up the existing syn structures and make them partially async using conditional return of Promises, where applicable.

It works for the labels but it does not work at all for doValidation which is basically the core validation routine, without making it all async.

I therefore will go down the path of making it fully async. Any objections please add here.

@jankapunkt Any updates on this async computations?

aashutoshshr avatar Aug 15 '24 01:08 aashutoshshr

@aashutoshshr I got stuck by https://github.com/serut/meteor-coverage/pull/95 which blocks most of my conributions right now, since without decent coverage it's really time-consuming and stressful to migrate/refactor code.

jankapunkt avatar Aug 15 '24 07:08 jankapunkt

@StorytellerCZ I released a 2.0.0 as of today. It's stable in what it does and resolved the correct 2x/3x versions dependencies. Regarding async compatibility: we should make a vote

jankapunkt avatar Aug 21 '24 09:08 jankapunkt