meteor-roles icon indicating copy to clipboard operation
meteor-roles copied to clipboard

Add Typescript declarations

Open bbenoist opened this issue 5 years ago • 7 comments
trafficstars

Since Meteor now supports TypeScript, it would be nice to have type definitions on this package.

Documentation: https://www.typescriptlang.org/docs/handbook/declaration-files/introduction.html Template: https://www.typescriptlang.org/docs/handbook/declaration-files/templates/module-d-ts.html

bbenoist avatar Nov 21 '19 00:11 bbenoist

Might also be a good time to take this package into TypeScript ... PRs are welcome. Please ping me if you're interested to get started with it.

SimonSimCity avatar Nov 21 '19 11:11 SimonSimCity

If we want to stay at plain javascript, some library like tsd-jsdoc might be valuable. We currently annotate all our code with comments compatible with YUIDoc - where we might need to switch to jsdoc.

SimonSimCity avatar Nov 22 '19 07:11 SimonSimCity

Might also be a good time to take this package into TypeScript ... PRs are welcome. Please ping me if you're interested to get started with it.

Maybe this can be of help https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/meteor-roles/index.d.ts to update it to version 3 . (That is the type definitions for v1.2.14)

diavrank avatar Nov 19 '20 22:11 diavrank

Does anyone still have interest in moving this to support v3.2.3? I badly need this library to work with that version and below and would be willing to contribute

wallind avatar Jan 23 '21 03:01 wallind

https://github.com/wallind/DefinitelyTyped/tree/bump-supported-version-to-2.1.0-meteor-roles

To get the ball rolling I'm working on getting @types/meteor-roles to support 2.1.0 on the branch above. If anyone wants to participate hit me up

wallind avatar Jan 23 '21 18:01 wallind

is there any newness about this?

diavrank avatar Sep 30 '21 15:09 diavrank

https://github.com/wallind/DefinitelyTyped/tree/bump-supported-version-to-2.1.0-meteor-roles

To get the ball rolling I'm working on getting @types/meteor-roles to support 2.1.0 on the branch above. If anyone wants to participate hit me up

Got any updates on this ?

Clovel avatar Apr 12 '22 15:04 Clovel

With v3.6.2 types should be all set. In the future version of roles package we should move to TypeScript.

StorytellerCZ avatar Feb 03 '24 19:02 StorytellerCZ