core icon indicating copy to clipboard operation
core copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

Check if the 'tokenAddress' is a smart contract before querying further in getTokenStandardAndDetails

Open adonesky1 opened this issue 3 years ago • 1 comments

We should make getTokenStandardAndDetails fail faster if passed an address that does not point to any smart contract code.

adonesky1 avatar Jul 15 '22 20:07 adonesky1

This PR generally looks good! This PR title is not very good though, it doesn't explain the purpose of the change (though the description does). It would be appreciated if the title could be updated to reflect the motivation, as it will be used to generate the changelog entry and would leave us with less work to do in release prep.

Gudahtt avatar Aug 02 '22 13:08 Gudahtt

very stale

adonesky1 avatar Sep 26 '23 16:09 adonesky1