Maksym Vlasov

Results 66 comments of Maksym Vlasov

>Since --retry-once-with-cleanup only retries once, the races would still happen and be visible, I tested it a few times on a repo with more than 200 lockfiles with paralelizm=64, and...

Oh, okay, it possible to commit broken checksum in some corner cases ![image](https://github.com/antonbabenko/pre-commit-terraform/assets/11096782/9bc28f53-d174-499c-81b4-7c58bf0b8a18) There should be a retry and it is specified in the configuration, but it never happened, and...

For some reason, `"override_json": null` exist in state, when it should be removed from the state Example: ```json { "version": 4, "terraform_version": "1.3.9", "serial": 13, "lineage": "fe5ffc8a-776c-9548-36c5-0b43c266ccb1", "outputs": {}, "resources":...

Workaround: to fix the state without state manipulations, you need change resources which had the `override_json` field, and then apply. For example: 1. In `data.aws_iam_policy_document`, change `Sid` 2. Run `terraform...

Well, I think now it's completely outdated so there is no sense to keep that PR open

That pretty much looks like the [current terraform_docs realization](https://github.com/antonbabenko/pre-commit-terraform/blob/07c6764c309d14fd37536e6c679354ab99c59a59/hooks/terraform_docs.sh#L242), jfyi. So will be a good idea to look into it to understand how to +- do the same as a...

@oviliz be sure that you use `gawk` awk not `mawk`. That's root cause in most cases

Okay, need to add a DEBUG log level, set log level to INFO by default, and move mostly all of these logs to the DEBUG lvl ![image](https://github.com/antonbabenko/pre-commit-terraform/assets/11096782/ad9ad40a-3801-409d-a12e-09761e6083f2)

Hi It could be simply done by adding `__GIT_WORKING_DIR__` support Here is example https://github.com/antonbabenko/pre-commit-terraform/pull/399

You're right. That's a bug in checkov - it returns wrong exit code