MaulingMonkey

Results 47 comments of MaulingMonkey

This would be a breaking change - I believe this should target the `dev` branch instead of the `0.3` branch?

I'll also note that an alternative implementation per the rambling (Sound)Interface suggestions might be desirable, that would limit AsIUnknown to "sound" implementations? ```rust pub trait AsIUnknown : SoundInterface { fn...

I'm not sure if this would technically be a breaking change in some strange edge cases involving Fn type inference? Would it be appropriate to target `dev` instead of `0.3`?...

webauthn.h implies several of these structs might gain additional fields in the future (and in fact has comments implying this happened a few times already before `WEBAUTHN_API_VERSION_1` as found in...

> Thus, it's very likely that I missed something! For what it's worth, these are pretty spot on as far as I'm concerned! Good stuff! 👍 - [Organization of code](https://github.com/retep998/winapi-rs/blob/0.3/CONTRIBUTING.md#organization-of-code)...

I recently wrote `json-spanned-value = "0.2"` ([github](https://github.com/MaulingMonkey/json-spanned-value), [crates.io](https://crates.io/crates/json-spanned-value), [docs.rs](https://docs.rs/json-spanned-value/)) to tackle this. Caveats: * Currently requires the JSON be loaded into memory first * Byte offsets only, you'll need to...

Scanning `std` as an end-user of `cargo about` is annoying - unless you're building std yourself (via `cargo-xbuild`, `xargo`, `cargo -Z build-std`, etc.) you may not have the Cargo.toml of...

Being able to customize this would also enable you to protect against malicious .tmx files opening arbitrary files on disk, which could be a problem if you want to allow...

For bonus points, making this async/future based would make it easier to integrate into the browser I believe.

This can *really* **really** help for Android builds as well. On professional C++ codebases I've previously cut link times from >1 minute to ~10 seconds - per project (many) x...