EmailChecker icon indicating copy to clipboard operation
EmailChecker copied to clipboard

always return true

Open Grald opened this issue 9 years ago • 7 comments

i am using laravel 5.2 always return true even if wrong email address provided

Grald avatar Oct 05 '16 13:10 Grald

/ping @olsgreen ;)

MattKetmo avatar Oct 06 '16 13:10 MattKetmo

@Grald Are you using the validator or trying to use it via DI or a facade?

olsgreen avatar Oct 06 '16 14:10 olsgreen

I'm seeing this, too, in Laravel. I've tried using it via DI and by plain instantiation (new EmailChecker).

josephsong avatar Apr 21 '17 17:04 josephsong

@josephsong Which version of Laravel are you using?

olsgreen avatar Apr 21 '17 17:04 olsgreen

Actually, Lumen v5.3.3.

josephsong avatar Apr 21 '17 17:04 josephsong

Well, it is funny. If I use yopmail.com as the domain for the test email, it does return false on the isValid call. But for any others I've tried from the list in this package, it still returns true.

josephsong avatar Apr 21 '17 17:04 josephsong

It seems that any of the domains in tests/EmailChecker/Tests/Adpater/BuiltInAdapterTest.php do come back as false. But any others in res/throwaway_domains.txt come back as true.

I had just successfully implemented this package in WordPress, and all domains in the throwaway_domain.txt are marked as invalid. Seems to be something specific to Laravel/Lumen.

josephsong avatar Apr 21 '17 17:04 josephsong