masonite icon indicating copy to clipboard operation
masonite copied to clipboard

Published 20 hours ago • verified publisher icon MasoniteFramework

Change Redis driver to use incrby methods

Open goophps opened this issue 3 years ago • 5 comments

Describe the bug

Hi, why do you want to do this? and poor performance image

Why not do this? image

Expected behaviour

No response

Steps to reproduce the bug

No response

Screenshots

No response

OS

Linux

OS version

deepin

Browser

No response

Masonite Version

4.15.0

Anything else ?

No response

goophps avatar Jun 24 '22 08:06 goophps

Hello, don't write this code like this, it provides the correct way to write it, why not use it?

goophps avatar Jun 25 '22 07:06 goophps

We will get to it. The issue is open I didn't close it. If you want to see this fixed then please open a PR and I will review it. If not then please wait until we get to this issue

josephmancuso avatar Jun 25 '22 10:06 josephmancuso

thank you for your work

goophps avatar Jun 25 '22 19:06 goophps

@josephmancuso
Using Driver native methods where they exist would be preferable as it incurs less overhead (hits on the store).

circulon avatar Jun 26 '22 04:06 circulon

@josephmancuso This is really a moot point now as PR #686 covers this by updating an internal cache for these methods eg .increment() and .decrement() so the native driver methods are no longer relevant to setting incremented/decremented values directly in the store

circulon avatar Jun 27 '22 08:06 circulon