ccls

ccls copied to clipboard

As like other IDEs (Eclipse, ..) , it's better to show line of each reference in caller hiearchy, Instead of caller's start line. For example, if caller has a lots of lines, it's annoying to find which line calls current symbol in which context or condition.

Ready to merge in my opinion.

• I remember someone suggested to use the function line instead of the call site for caller hierarchy. It may not be obvious from the UI which functions are the callers.
• src/messages/ccls_call.cc is used by both caller and callee hierarchies. This change will break callee hierarchy.
• foo may be called multiple times in bar. Creating duplicate nodes in the caller hierarchy is redundant.

• I remember someone suggested to use the function line instead of the call site for caller hierarchy. It may not be obvious from the UI which functions are the callers.
• src/messages/ccls_call.cc is used by both caller and callee hierarchies. This change will break callee hierarchy. ===> First of all, my change only shows function line only in case of caller hiearchy. ===> In case of callee, it's better to show definition of callee, but it's not case in caller. ===> IMHO, it's better to take different strategy between caller and callee.

• foo may be called multiple times in bar. Creating duplicate nodes in the caller hierarchy is redundant. ===> This is reasonable point, but this may harm efficiency of using caller hiearchy ===> For every entry in graph, user should find the location which call the function.

I think there is trade off between function line and reference line. If then, how about creating new parameter option to show reference line instead of function start line?