colors.js icon indicating copy to clipboard operation
colors.js copied to clipboard

Published 20 hours ago • verified publisher icon Marak

Revert infinite loop bug

Open EricPKerr opened this issue 3 years ago • 4 comments

This reverts a critical error described here: https://github.com/Marak/colors.js/commit/074a0f8ed0c31c35d13d28632bd8a049ff136fb6

EricPKerr avatar Jan 08 '22 23:01 EricPKerr

LGTM :heavy_check_mark:

oliviergf avatar Jan 09 '22 23:01 oliviergf

I'm unable to merge or npm publish this. Is a maintainer able to do that?

EricPKerr avatar Jan 10 '22 03:01 EricPKerr

It won't be merged. The author did this on purpose, it's not a mistake nor a bug. They did similar things on their other packages, such as Faker.js (they removed the source, and push v6.6.6 to NPM that breaks everything).

Nivl avatar Jan 10 '22 03:01 Nivl

Don't merge this, it breaks functionality of the new library and how I use it.

G2G2G2G avatar Jan 10 '22 19:01 G2G2G2G