Manav Aggarwal comments

Results 106 comments of


                                            Manav Aggarwal

Block processing should use storage atomically

A team ran into an issue when using `status` and `block_results` endpoint that noticed this issue. From @tzdybal: We save block information and update height in the code just before...

Clean up stale block cache elements at some height interval

Move DAIncluded and seen hashes to persistent memory

Random namespace ID for development

[Local-DA](https://github.com/rollkit/local-da) is now used for any local rollup development now, so needing random namespaces is unindeed. Please feel free to reopen if things change.

Multi-aggregator mode

Closing since decentralized sequencers aren't a priority.

GM CI

Close this after this is in a cosmos-sdk branch.

GM CI

Closing as stale issue.

Basic Validation for Block Data

Fine to remove this method as it's not part of an interface.

Block Serialization round trip test fails with empty Tx or RawRootsList struct(s)

This seems like an issue with protobuf treating empty slices and nil values the same when serializing. This is because protobuf automatically uses the `omitempty` tag when doing `buf generate`....

Use DA commitment (obtained using`blob.CreateCommitment`) in DataHash instead of Merkle Hash

Will be part of https://github.com/rollkit/rollkit/issues/829

[EPIC] Separate SignedHeader and Data into 2 different blobs

Note: We can use something like Brotli compression for the Rollup block data part, but we shouldn't do it for headers so that rollup light nodes don't have to de-compress...