Gerasimos Chourdakis

Results 416 comments of Gerasimos Chourdakis

For smart pointers we should probably not use `unique_ptr`: it would be ugly, as we should not use `make_unique`, which is C++14 (OpenFOAM requires C++11, although preCICE requires C++14, so...

Thanks! My worry is not about ABI, it is about sticking to the minimum requirements of the solver, as we also want to target older systems (usually compute clusters). But...

I assume this would again be essentially one / a couple of files, right? Why not put it in a `tools/` directory in the `elastic-tube-1d`? I assmume that people would...

See branch https://github.com/precice/openfoam-adapter/tree/OpenFOAM9 and the `_OpenFOAM9` archive in our [releases](https://github.com/precice/openfoam-adapter/releases) for a compatible version.

Hi @jaydeshpande, thank you very much for your nice words and your interest in preCICE! At the moment, the radiation part is not included in the calculation. However, you could...

An instrinsic heat flux boundary condition would simplify the implementation, yes. But then we also need to make sure that this boundary condition is supported by several solvers, in several...

Good point. This is currently a warning + trigger exit. A rewording of the warning and removing the `return false` should do the job.

I would not rely on the sanity of the user, there are many reasons on why one can misconfigure this. If they misconfigure it, I am not sure if preCICE...

In the constructor it would be the best, but it currently does not have enough information. In any case, we should refactor this part in the future to not need...

> This issue should be fixed with [precice/precice#686](https://github.com/precice/precice/pull/686) which was released with preCICE `2.1.0`. @MakisH Can you confirm this? It is not very easy for me to test this at...