Jake Potrebic

Results 384 comments of Jake Potrebic

> If this should really include a toggle for the actions after the change then I feel like this should be a separate toggle (e.g. "triggerAdvements" or something along that...

> If I add a default method with an additional parameter and override that, then the original method will not be overridden and thus it will be uncompilable. I might...

@ryantheleach can you confirm that the changes made in the linked PR resolve your issue?

Rebased for 1.18.2 Now resolves 2 open issues.

Ok, tested and this fixes the recursion issue, and the new API works as expected. I'll wait for a 2nd approval since this is new API and not a simple...

This kinda sorta duplicates an already existing PR https://github.com/PaperMC/Paper/pull/6613

I this the configurability of #6613 is better, leaves it open to server owners with sane defaults. However I do think it's better to wipe tile entity data instead of...

> I do not like the name `DataProperty`. What is wrong with just `Property`? These are not limited to just blocks, as the game also uses them for fluids (and...