MFC

MFC copied to clipboard

I propose moving all monopole source terms in `m_rhs.f90` into a new module (`m_monopole.f90`) and viscous terms (which right now are in a separate subroutine in `m_rhs.f90` to yet another...

sbryngelson

Bubble code is not in `m_rhs`?

1

This code used to be in the `m_bubbles` modules, but now it's also in `s_compute_rhs`? Also, `s_compute_rhs` is 1863 lines long. https://github.com/MFlowCode/MFC/blob/ecbcb72cc93563bb071118c447e84c3dabdf6341/src/simulation/m_rhs.f90#L1113-L1321

sbryngelson

All physical quantities become "infinity".

22

Hi, I tried to reproduce the case of S.Sembian(2016), but icfl condition in the run_time.inf became _infinity_ . And all the physical quantities including alpha, pressure, velocity also became _infinity_....

HIT-CFD-group

Dead code

1

Dead code needs to me removed. We seem to have thousands of lines of it. Here is one example: https://github.com/MFlowCode/MFC/blob/fc40ccea496abd8e3b81a543c6b5ba80af589dfb/src/simulation_code/m_rhs.f90#L358-L544 We also have two entire RHS functions: https://github.com/MFlowCode/MFC/blob/fc40ccea496abd8e3b81a543c6b5ba80af589dfb/src/simulation_code/m_rhs.f90#L2928 https://github.com/MFlowCode/MFC/blob/fc40ccea496abd8e3b81a543c6b5ba80af589dfb/src/simulation_code/m_rhs.f90#L1010 The...

sbryngelson

Module files are simply too long

1

Our module files are simply too long, no matter how you think about the code abstractions. I suggest that modules should not be longer than 1000 lines, though much shorter...

sbryngelson

Equation of state is not DRY

3

The equation of state is used to compute the pressure from the variables. This EOS changes slightly for different models. The EOS implementation is repeated several places in the code,...

sbryngelson

contributors guide

2

Need a file on how to contribute to MFC.

sbryngelson

Add Surface Tension

2

## Description This PR adds the surface tension model of Schmidmayer et. al 2017 to MFC. Fixes #276 ### Type of change - [x] New feature (non-breaking change which adds...

wilfonba

Fix benchmark divide by zero with proper error message

3

I'm not sure why it happens but we have an issue where we sometimes get a divide by zero in benchmark diff (e.g., https://github.com/MFlowCode/MFC/actions/runs/8610942830/job/23597260867?pr=285): ``` .=++*: -+*+=. | [email protected] [Linux]...

sbryngelson

Operator splitting, adaptive time stepping, and other fixes for mixing layer and bubbles

31

## Description This PR introduces several new features including 1. Strang operator splitting with adaptive time stepping strategy (`adap_dt = T`), 2. Solving the number density equation directly and computing...

hyeoksu-lee