Ref #3743

Changes made in this Pull Request:

• Changed more tests to use approx and assert_allclose rather than assert_almost_equals and assert_array_almost_equals.

PR Checklist

• [x] Tests?
• [x] Docs?
• [x] CHANGELOG updated?
• [x] Issue raised/referenced?

Hello @rzhao271! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2022-07-23 19:50:07 UTC

Codecov Report

Merging #3760 (275fa68) into develop (50b8fdb) will increase coverage by 0.00%. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3760   +/-   ##
========================================
  Coverage    94.30%   94.31%           
========================================
  Files          192      192           
  Lines        24708    24752   +44     
  Branches      3328     3338   +10     
========================================
+ Hits         23302    23345   +43     
- Misses        1358     1359    +1     
  Partials        48       48           

Impacted Files	Coverage Δ
package/MDAnalysis/core/topologyattrs.py	96.58% <0.00%> (-0.07%)	:arrow_down:
package/MDAnalysis/core/groups.py	98.58% <0.00%> (ø)
package/MDAnalysis/topology/PDBParser.py	100.00% <0.00%> (ø)
package/MDAnalysis/topology/ExtendedPDBParser.py	100.00% <0.00%> (ø)
package/MDAnalysis/coordinates/PDB.py	95.09% <0.00%> (+0.23%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 50b8fdb...275fa68. Read the comment docs.

Will also move more error messages to their own variables

That's not a style requirement by the way, I suggested moving a few things because you had PEP8 violations, as long as pep8speaks is happy, I would vote for not changing things around.

Is this PR ready to merge?

Is this PR ready to merge?

Sorry @rzhao271 the last week has been quite busy, I'll try to get to re-reviewing over the next couple of days.

Bump. Also let me know if you need me to change more test files before this PR can be merged. Edit Dec 4: Closing this PR for now due to inactivity and also because I'm busier these days.