mstickereditor

mstickereditor copied to clipboard

I tried it and compiled it but my stickers are not working (?) The media files appear to be there but nothing is showing, not even in Element.

https://0x416c69.github.io/stickerpicker/web/#pack-tg_name_MyQuby (latest pack)

My synapse server is up to date. Is it required to enable dynamic_thumbnails in synapse for this to work? When trying to fetch those webp images, I'm getting this error 400:

{"errcode":"M_UNKNOWN","error":"Cannot find any thumbnails for the requested media ([b'ag5.ir', b'qAsAxJsWpWXAlGaJaeZrJwQC']). This might mean the media is not a supported_media_format=(image/jpeg, image/jpg, image/webp, image/gif, image/png) or that thumbnailing failed for some other reason. (Dynamic thumbnails are disabled on this server.)"}

Pack: https://t.me/addstickers/MyQuby

---

issue by @0x416c69 imported from https://github.com/maunium/stickerpicker/pull/63#issuecomment-1707534031

@0x416c69 Which feature flags are enable and with mstickereditor version did you use?

@0x416c69 Which feature flags are enable and with mstickereditor version did you use?

I've downloaded the latest rust/cargo package with LLVM 16 (inside windows) and followed what was in the CI action job and compiled the master's HEAD (@ 76f13435201cfcc8c82ad71e59061c7bcc93f9f2)

I've also ran your unit tests, they've all succeeded in my machine (the machine that I've used to import those stickers)

There wasn't any errors or warnings when I executed the binary as well, it ran successfully

Edit: Do you have a working animated sticker so I can try it? Maybe the problem is with my animated sticker

followed what was in the CI action job

So lottie feautre-flag should be disable. The mention pack is animated so import should not work. I think I have only disable the file conversion and do not create a warning/error if the lottie feature is disable (same issue for ffmpeg). So the original files (zstd compress lottie) was uploaded instead (which is not supported by element).

I should fix this behaviors. They are three options:

• uploading the (uncompressed) lottie/webm files
• exiting with an error
• create a warning and do not upload anything

I've also ran your unit tests, they've all succeeded in my machine (the machine that I've used to import those stickers)

Aslong you did not test ignored-test this do nothing. (cargo test --no-default-features --features ffmpeg,log -- --include-ignored but your telegram access token must be set as ENV for this)

(cargo test --no-default-features --features ffmpeg,log -- --include-ignored but your telegram access token must be set as ENV for this)

Should I run it and send you the output here?

Should I run it and send you the output here?

This should not create useful data. Since lottie test are also disable if the lottie feautre-flag is not set.

But you can run it, to verify if video sticker and normal sticker works ~~(keep in mind that this would also upload sticker to your matrix server)~~. Using the binary to import sticker packs should also work.

first patch is out b85d0d3cd5b04775565729ba0d0e45fd749d22fe. Animated sticker will be always unpack now. However since lottie and webm are not support by matrix client it would be a good idea to still create an warning/error.

I think the best way would be to replace the --noformat flag with --keep-webm and --keep-lottie. If the flag is not set a warning should be created and the sticker would be skipped.

@0x416c69 can you retest the current main? Now an error is created if someone tries to import an animated/video sticker and the associated feature flag is disable.

can this be closed?