pytorch-lightning icon indicating copy to clipboard operation
pytorch-lightning copied to clipboard

Published 20 hours ago • verified publisher icon Lightning-AI

[CLI] change cluster creation cost savings mode default

Open nicolai86 opened this issue 3 years ago • 2 comments

What does this PR do?

This PR changes the default for cluster creation: instead of having customers opt-into cost savings mode, we'll ask them to opt-out of cost savings mode.

Based on internal discussions - see LAI2-10134

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • [ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • [ ] Did you read the contributor guideline, Pull Request section?
  • [ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [ ] Did you make sure to update the documentation with your changes? (if necessary)
  • [x] Did you write any new necessary tests? (not for typos and docs)
  • [ ] Did you verify new and existing tests pass locally with your changes?
  • [ ] Did you list all the breaking changes introduced by this pull request?
  • [ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR. Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • [ ] Is this pull request ready for review? (if not, please submit in draft mode)
  • [ ] Check that all items from Before submitting are resolved
  • [ ] Make sure the title is self-explanatory and the description concisely explains the PR
  • [ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

nicolai86 avatar Aug 10 '22 02:08 nicolai86

Do we have the "cluster" feature documented already?

hhsecond avatar Aug 10 '22 06:08 hhsecond

Wouldn't it make sense to turn it around and have an enable-performance flag instead?

lantiga avatar Aug 10 '22 07:08 lantiga

Wouldn't it make sense to turn it around and have an enable-performance flag instead?

I agree, avoiding the negation makes the flag more readable. let me change that.

nicolai86 avatar Aug 10 '22 14:08 nicolai86

Do we have the "cluster" feature documented already?

the documentation is in a pending PR, I'll leave a comment to adjust it according to this change. @hhsecond

nicolai86 avatar Aug 10 '22 14:08 nicolai86