LibreHardwareMonitor icon indicating copy to clipboard operation
LibreHardwareMonitor copied to clipboard

DIMMs temperature

Open lich426 opened this issue 5 years ago • 100 comments

I want to implement DIMMs temperature, which category should I put it in? fan controllers or new category?

1

lich426 avatar Feb 25 '21 02:02 lich426

I as a User would expect it in the already existing "RAM" category. Looking forward to have my DIMM Temps shown in LHM! ;)

Eno77 avatar Mar 04 '21 10:03 Eno77

1 I tested it with Intel cpu. does anyone have an amd cpu? Please help me with this test.

LibreHardwareMonitor.zip

lich426 avatar Mar 05 '21 07:03 lich426

good work!

grafik

one thing: should be DIMM 2 and DIMM 4 on my rig instead od DIMM 2 and 3 (if count starts on 1) - otherwise it should be DIMM1 and 3

Eno77 avatar Mar 05 '21 08:03 Eno77

Could you check the DIMM number with HWiNFO (https://www.hwinfo.com)? thanks in advance.

lich426 avatar Mar 05 '21 09:03 lich426

Hmm its consistent with HWInfo, but CPU-Z shows the right Numbers:

grafik

Eno77 avatar Mar 05 '21 10:03 Eno77

First of all, thank you for finally adding dimm temperatures support! Same issue with DIMM #2 and DIMM #3 here (HWiNFO shows it this way too). MSI X570 motherboard, Ryzen 7 5800X CPU.

norceno avatar Mar 05 '21 11:03 norceno

smbus address of the dimm sensor is 0x18 to 0x20 your dimm address will be 0x1A and 0x1B. therefore, index becomes 2 and 3. you can check it through the System Infomation Viewer program. (http://rh-software.com) 1

but it doesn't matter. If there is no problem, I will do a pull request soon.

lich426 avatar Mar 05 '21 11:03 lich426

Yes, since you can rename it, it would not be an issue. Thanks again for the work!

grafik

Eno77 avatar Mar 05 '21 11:03 Eno77

I just tried it and a couple of odd things. My DIMMs are named DIMM 4 and 8, which is odd as my motherboard only has 4 slots. The temperature is also a bit odd (given that room temperature is already higher): image

EDIT: And thanks for looking into this @lich426, these kinds of additions are appreciated 👍

PhyxionNL avatar Mar 05 '21 12:03 PhyxionNL

maybe it's because the dimm chipset is different I don't know all of this either I want someone to modify it after this code is merged

lich426 avatar Mar 05 '21 12:03 lich426

does anyone have an amd cpu? Please help me with this test.

amd

pomianowski avatar Mar 17 '21 09:03 pomianowski

image

Using a Ryzen 7 5800X

Cubox avatar Mar 18 '21 12:03 Cubox

There is a DIMM8 which is not a thing and for some reasons at some point, dimm 2 was on fire. Send me any updated file to test out if you update the code, I have been waiting for DIMM temperature in LHM for so long!

Cubox avatar Mar 18 '21 12:03 Cubox

I have already submitted the PR. (#399)

lich426 avatar Mar 19 '21 00:03 lich426

I have already submitted the PR. (#399)

You can still make more commits to your repo, they will be added to the PR. I think fixing the ghost DIMM and possibly the wrong temperature reading would be better done now to ensure the PR goes through

Cubox avatar Mar 19 '21 02:03 Cubox

I've given the PR another try and I do not think it's working correctly. My AMD sensors have the wrong number, Intel is probably similary wrong. I think that can be combined with https://docs.microsoft.com/en-us/windows/win32/cimwin32prov/win32-physicalmemory -> the Tag property gives the correct number for me (Physical Memory 1 and Physical Memory 3).

What's another concern is that, unlike the results from @Cubox, my sensors seem to return bogus data. They're certainly not 15 and 5 degrees C. HWiNFO doesn't return anything here either, so I guess the detection isn't working well.

PhyxionNL avatar Mar 19 '21 08:03 PhyxionNL

smbus address of the dimm sensor is 0x18 to 0x20 therefore, the index is as follows 0x18 : 0 0x19 : 1 0x1A : 2 0x1B : 3 ...

I only provided a way to get a dimm temperature sensor using a smbus. each chipset of dimm sensors will have a different method of importing temperature sensors. however, I don't know how to handle exceptions for chipsets. I want someone to do elaborate coding. I referred to this datasheet (https://www.onsemi.com/pdf/datasheet/cat34ts02-d.pdf)

lich426 avatar Mar 19 '21 09:03 lich426

Is there a way to distinguish between DIMM with and without a temperature sensor?

Eno77 avatar Mar 19 '21 09:03 Eno77

It is similar to i2cdetect of Linux. when looking for a chipset connected to i2c, if the address and value are the same, there is a chipset connected. ex) a0b4be76-9fc4-433e-979f-b915e1ee01df-image (1)

the source code I worked on has SmbDetect method.

lich426 avatar Mar 19 '21 09:03 lich426

Any update on this feature?

Cubox avatar May 25 '21 23:05 Cubox

Any update on this feature?

The problems mentioned are not resolved yet.

PhyxionNL avatar May 26 '21 08:05 PhyxionNL

does anyone have an amd cpu? Please help me with this test.

Working well here in FanCtrl. Missing the ability to graph it in LHM.

image

ghost avatar Jun 04 '21 23:06 ghost

The problems mentioned are not resolved yet.

Is there any chance we could merge the existing patch which appears to work quite well in some cases, with a view to adding more sensor IC support at a later date? It would be a shame if this were held back entirely until every memory module could be supported.

ghost avatar Jun 05 '21 00:06 ghost

Having used the dll from the PR since march to add DIMM capability to FanControl, I have nothing to complain about. It does see a phantom 8th stick at 13°C, but I can just ignore it. image

Merging the PR would allow everyone to at least try and see if their DIMMs are properly picked up, and use those values until this is entirely fixed.

Cubox avatar Jun 05 '21 00:06 Cubox

@Cubox Can you try this one: https://github.com/LibreHardwareMonitor/LibreHardwareMonitor/actions/runs/960007578 I don't seem to have any DIMM with temperature sensor here.

PhyxionNL avatar Jun 22 '21 08:06 PhyxionNL

@Cubox Can you try this one: https://github.com/LibreHardwareMonitor/LibreHardwareMonitor/actions/runs/960007578 I don't seem to have any DIMM with temperature sensor here.

I'm afraid this one broke it for me. No temperatures in this version. All of them have been good for me so far otherwise.

ghost avatar Jun 22 '21 11:06 ghost

Broken for me too, no DIMM Temps with this one.

Eno77 avatar Jun 22 '21 18:06 Eno77

@Cubox Can you try this one: https://github.com/LibreHardwareMonitor/LibreHardwareMonitor/actions/runs/960007578 I don't seem to have any DIMM with temperature sensor here.

not a single DIMM :(

Cubox avatar Jun 23 '21 15:06 Cubox

@xcasxcursex @Eno77 @Cubox Anything with this one? https://github.com/LibreHardwareMonitor/LibreHardwareMonitor/actions/runs/964965830

PhyxionNL avatar Jun 23 '21 16:06 PhyxionNL

image

Cubox avatar Jun 23 '21 16:06 Cubox