Petals

Petals copied to clipboard

We currently use https://github.com/vanpra/compose-material-dialogs But Material Design is offering the same component, but with more customization https://material.io/components/time-pickers/android#using-time-pickers

Hi, I would like to work on this issue, can you assign me?

Absolutely!

Hi @mkicina ! Are you still working on this one?

Hi @LeoColman, sorry for not reaching you sooner. I have other assignments in the past few weeks, but I will resolve this in the next one or two weeks. Hope it's okay.

No problems at all! Take as long as you need. Just making sure you haven't forgotten :)

Hi, I have problem build project after latest pull. I was given this error: Could not get resource 'https://plugins.gradle.org/m2/org/slf4j/slf4j-api/1.7.22/slf4j-api-1.7.22.pom'.

When I try to access that resource, I was given 403 error. Do you know where could be problem? Thanks :)

Interesting. Does that happens when you just open the project in Android Studio after cloning?

I actually dont know where was the real problem, but I have simillar issue with my othres Android projects. After restarting my notebook and rebuiding projects it works fine. I now can access that resource from browser, no 403 error. So sorry for any inconvenience :)

Good old rebooting FTW!

Hi @mkicina ! Do you think you'll manage to implement this? Do you need any help? Do you want me to unassign it from you and in the future you can come back to it?

Hi @LeoColman ! I am actually working on it. In a week it should be ready, sorry for delay :)

Don't worry, no delay at all!

It's just that sometimes people forget, so I ping them every now and then :) Take as much time as you need

Hi @LeoColman!

Sorry to interrupt you, but I have this one thing I want to check with you.

If I understand it correctly, your app is using Jetpack Compose, and your suggested material components are not yet supported on Jetpack compose. https://m3.material.io/components/time-pickers/overview

Check Resources -> Implementation -> Jetpack Compose

I have some experience with Android and Kotlin, but not yet with Jetpack Compose, so can you please make it clear for me if it is possible?

I suppose we can use the ones from https://github.com/material-components/material-components-android/blob/master/docs/components/TimePicker.md

This is "the old library". It's not supported in compose yet, but I think we can deal with it by using AndroidView

https://developer.android.com/jetpack/compose/interop/interop-apis

I don't think I can manage to resolve this issue now, because it is not supported yet on compose. Do you think that I can resolve simillar issue about date and time pickers? It is this issue: https://github.com/LeoColman/Petals/issues/67

You can assign it to me and then tell me more about what customization are you expecting.

Replaced by #601