Context (issues, jira)

Description / Usage

Expectations

• [ ] Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
• [ ] No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/CBMXXfb9h4T8fVcRpnsn9KJAoeVa
✅ Preview: https://ledger-live-common-git-fork-elrondnetwork-esdt-1036d0-ledgerhq.vercel.app

Codecov Report

Merging #1585 (1688858) into develop (2298702) will decrease coverage by 12.70%. The diff coverage is n/a.

:exclamation: Current head 1688858 differs from pull request most recent head 5252276. Consider uploading reports for the commit 5252276 to get more accurate results

@@             Coverage Diff              @@
##           develop    #1585       +/-   ##
============================================
- Coverage    68.57%   55.87%   -12.71%     
============================================
  Files          546      518       -28     
  Lines        23426    22270     -1156     
  Branches      6165     5339      -826     
============================================
- Hits         16064    12443     -3621     
- Misses        7319     9744     +2425     
- Partials        43       83       +40     

Impacted Files	Coverage Δ
src/currencies/chopCurrencyUnitDecimals.ts	7.14% <0.00%> (-92.86%)	:arrow_down:
src/families/ethereum/mock.ts	6.34% <0.00%> (-92.07%)	:arrow_down:
src/currencies/sanitizeValueString.ts	9.09% <0.00%> (-90.91%)	:arrow_down:
src/families/cosmos/mock.ts	3.52% <0.00%> (-89.77%)	:arrow_down:
src/account/groupOperations.ts	9.23% <0.00%> (-89.24%)	:arrow_down:
src/currencies/CurrencyURIScheme.ts	11.53% <0.00%> (-84.62%)	:arrow_down:
src/families/stellar/js-getTransactionStatus.ts	12.50% <0.00%> (-83.93%)	:arrow_down:
src/mock/account.ts	12.80% <0.00%> (-83.27%)	:arrow_down:
src/countervalues/api/api.mock.ts	13.79% <0.00%> (-81.04%)	:arrow_down:
src/hw/getAppAndVersion.ts	13.33% <0.00%> (-80.00%)	:arrow_down:
... and 443 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2298702...5252276. Read the comment docs.

@AlexandruPislariu can you merge master in? It should include your work from ledgerjs

please also confirm if testing against LLD have the feature overall working (you can see token accounts, you can send them over, etc..) – maybe would be great to organize a call / if you have a video of the feature working. Thanks

please also confirm if testing against LLD have the feature overall working (you can see token accounts, you can send them over, etc..) – maybe would be great to organize a call / if you have a video of the feature working. Thanks

Currently we encounter an issue with esdt token transactions, as soon as it is fixed we can organize a call. Also, can you please tell me how the token assets(like token logo) can be displayed in LLD?

@AlexandruPislariu Sorry about that, but it seems there are unsigned commits in this branch, can you please make sure all commits are signed? :pray: Thank you.

@haammar-ledger these commits are verfied with another GPG key which is no longer in my github account. I can't update the commit signature for a pushed commit.

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
ledger-live-common	✅ Ready (Inspect)	Visit Preview	May 18, 2022 at 6:10AM (UTC)