AutoSpotting
AutoSpotting copied to clipboard
Add CloudFormation region note
Issue Type
- Documentation Pull Request
Summary
Adds note as suggested in this issue for CloudFormation users attempting to launch outside us-east-1.
Code contribution checklist
- [x] The contribution fixes a single existing github issue, and it is linked to it.
- [ ] The code is as simple as possible, readable and follows the idiomatic Go guidelines.
- [ ] All new functionality is covered by automated test cases so the overall test coverage doesn't decrease.
- [ ] No issues are reported when running
make full-test. - [ ] Functionality not applicable to all users should be configurable.
- [ ] Configurations should be exposed through Lambda function environment variables which are also passed as parameters to the CloudFormation and Terraform stacks defined as infrastructure code.
- [ ] Global configurations set from the infrastructure stack level should also support per-group overrides using tags.
- [ ] Tags names and expected values should be similar to the other existing configurations.
- [ ] Both global and tag-based configuration mechanisms should be tested and proven to work using log output from various test runs.
- [ ] The logs should be kept as clean as possible (use log levels as appropriate) and formatted consistently to the existing log output.
- [ ] The documentation is updated to cover the new behavior, as well as the new configuration options for both stack parameters and tag overrides.
- [ ] A code reviewer reproduced the problem and can confirm the code contribution actually resolves it.
Coverage remained the same at 76.685% when pulling e4d8897e07503a1573501a215dddc51fcbf2a69a on brennv:add-launcher-note into d653fb3c685c45ea64ea983b8738470c44222fa6 on cristim:master.
Thanks for this contribution.
Please also mention that other regions can be used if using your own bucket in the desired region, but that we currently only host it in a bucket from us-east-1.
Additional regions are definitely possible, but I pay for this from my own pocket and with my current budget for AWS costs I can't afford to host it in more regions yet.
Thanks, I would have added something like: :warning: (:warning:) to make it more 'eye-catching' as it's some limitation
@brennv do you have a minute, otherwise I can take care of this?
@cristim You can deploy it to other regions by using https://docs.aws.amazon.com/AmazonS3/latest/dev/RequesterPaysBuckets.html.
I would still have to keep some 15 buckets în sync, and pay for the storage costs, for very little benefit. Speaking of, din anyone measure the impact of the current situation to the monthly runtime costs?
For the stable build users I'm going to do it upon demand, as part of the setup support.
Now that we use Docker images for the Lambda, the code should now run in any region, so this is no longer relevant.