awesomplete icon indicating copy to clipboard operation
awesomplete copied to clipboard

Published 20 hours ago • verified publisher icon LeaVerou

autocomplete="off" doesn't work in Chrome

Open FranciscoG opened this issue 7 years ago • 15 comments

using autocomplete="off" does not stop Chrome's autofill from working.

The current workaround is to pass a random value to it

I use autocomplete="nope" and it works great. You can put in any string value that is not "off" or "on" in there.

I suggest autocomplete="awesomplete"

https://www.20spokes.com/blog/what-to-do-when-chrome-ignores-autocomplete-off-on-your-form

https://stackoverflow.com/a/38961567/395414

link to the spec

FranciscoG avatar Aug 24 '18 15:08 FranciscoG

Thanks! PR?

LeaVerou avatar Sep 05 '18 23:09 LeaVerou

BTW I thought my PR would fix this but for the new Chrome's version, it didn't. 😭

antoinelyset avatar Sep 17 '18 11:09 antoinelyset

Ok, after some investigation, it seems to fix some cases and some not. Maybe you can try in your own context @FranciscoG.

antoinelyset avatar Sep 17 '18 15:09 antoinelyset

@antoinelyset your PR seems to have broken the autocomplete behavior in Firefox 63. I'm now seeing the native autcomplete menu on top of the Awesomplete menu:

screen recording 2018-09-21 at 01 38 pm

blvrd avatar Sep 21 '18 18:09 blvrd

Ugh, so I guess if it didn't fix it in Chrome and it broke it in Firefox, I'm gonna revert it until we figure out the best course of action.

LeaVerou avatar Sep 21 '18 18:09 LeaVerou

@LeaVerou thanks so much for the quick turnaround.

blvrd avatar Sep 21 '18 18:09 blvrd

No worries, though I did a release yesterday, and now I'm not sure what to do. :(

LeaVerou avatar Sep 21 '18 19:09 LeaVerou

Aargh. This is problematic indeed, no good solution...

For the record it did fix the Chrome's bug in pre-69 version. Since 69 it's back.

We should let it "off", but maybe being able to parametreize would be useful.

For the release, just bump it to 1.1.4, it will like 1.1.2 with some fixes included.

antoinelyset avatar Sep 24 '18 07:09 antoinelyset

Sorry about this! Very frustrating indeed that Chrome is inconsistent. My original solution worked for my needs at the time but I have since switched jobs and have not been able to test it since.

FranciscoG avatar Sep 24 '18 22:09 FranciscoG

Is there an anticipated timeframe for releasing the reverted change made in https://github.com/LeaVerou/awesomplete/pull/17162?

adamgruber avatar Oct 08 '18 18:10 adamgruber

Bump? Going to have to revert to using 1.12 because of this.

lukeramsden avatar Oct 18 '18 14:10 lukeramsden

I'm also wondering how (if) this issue can be resolved - I tried to get consistent "autocomplete" behaviour for IE11, FF and Chrome (showing the suggestion on first click), but with Chrome showing both dropdowns (while FF would need two clicks without additional lib) its a bit unsatisfying :-(

schober-ch avatar Oct 19 '18 06:10 schober-ch

I guess I should release a new version with the revert. Would that work for y'all? If so, I can do it later today.

LeaVerou avatar Oct 19 '18 10:10 LeaVerou

@LeaVerou Hate to bug but can we get an update on this? (Happy New Year 🎉 )

adamgruber avatar Jan 02 '19 14:01 adamgruber

Happy new year!!

Done, thanks for the ping! Now if only I could find some time to review all the outstanding PRs... :/

LeaVerou avatar Jan 07 '19 19:01 LeaVerou