Lakshan Fernando

Results 12 comments of Lakshan Fernando

/azp run runtime-extra-platforms

Retrying since the changes that caused dotnet/linker#2963 was reverted

Incorporating @sbomer suggestions [below](https://github.com/dotnet/runtime/issues/72415#issuecomment-1205546877) The native AOT application publishing experience is outlined below for supported scenarios for PublishAot property and when an explicit package reference to `Micsoroft.dotnet.ilcompiler` is present Publishing...

I would like to keep this open for a little longer. I need to clean up the tests in SDK and that requires the runtime changes to flow there. Will...

Validated the [test](https://github.com/dotnet/sdk/blob/release/7.0.1xx-rc1/src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs) in the rc1 branch, including cross-target scenario [without the explicit packages](https://github.com/dotnet/sdk/blob/main/src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs#L370-L371) in the project. However, the test will only be updated on the [main branch](https://github.com/dotnet/sdk/pull/27334/) and not...

Moving to 8.0 since there is a mitigation

Likely a test issue? Not sure where the test is though to check. Both the errors, [NETSDK1083 ](https://github.com/dotnet/sdk/blob/main/src/Tasks/Microsoft.NET.Build.Tasks/ProcessFrameworkReferences.cs#L514)and [NETSDK1183](https://github.com/dotnet/sdk/blob/main/src/Tasks/Microsoft.NET.Build.Tasks/ProcessFrameworkReferences.cs#L367) seem valid when rid is "invalid-rid"

[TrimTest](https://github.com/dotnet/winforms/blob/main/src/System.Windows.Forms/tests/IntegrationTests/TrimTest/TrimTest.csproj) project, which we are tracking as part of WinForms trimming, gives a similar view as above from sizoscope.

Yes, https://github.com/dotnet/sdk/pull/39402 and https://github.com/dotnet/windowsdesktop/pull/4227 should have addressed this.

> @LakshanF we are still including `PresentationNative_cor3.dll`, should it be included? Removed the WinForms profile in the PR, https://github.com/dotnet/windowsdesktop/pull/4462