LMMS
Mixers too large since #7037
System Information
Windows 11 but doesn't matter
LMMS Version(s)
latest git master
Most Recent Working Version
version just before the PR in question
Bug Summary
Ever since #7037 got merged, we have a horribly large mixer. Keeping this issue here for @michaelgregorius s reference.
Expected Behaviour
Mixer should not be this large
Steps To Reproduce
download/compile the latest nightly.
Logs
none
Screenshots / Minimum Reproducible Project
expected:
actual behaviour:
(ignore the theme because i use a theme from an older release)
Please search the issue tracker for existing bug reports before submitting your own.
- [X] I have searched all existing issues and confirmed that this is not a duplicate.
Windows 11 but doesn't matter
How do you know this doesn't matter?
I see a difference on master. The fader is the same size but it's left with a lot of space and looks like it was thinking of making the mixer section extend downwards but then had a second thought about it. Ubuntu 22.04, Display 1920x1080
Master as of summer 23
Laatest master 86363819c556a63e7666d173118a50013eb93ce9
How do you know this doesn't matter?
Assumption but looks like I'm wrong. Anyway the issue does exist.
I cannot reproduce it on my machine with the current master (86363819c55). For me it starts with the mixer with the minimum vertical size. Does this only happen with specific projects?
I think i get what's going on now. The mixer was not previously HiDPI compatible and had fixed size but now, the mixer is dynamic. This resize might be a side effect of that. I believe a fix for this might be more "compact" defaults which replicates the old size better. For instance, i use 1.25x scaling on windows and this new mixer view is reflecting that resize instead of giving the exact pixel sizes.
@zonkmachine your "mixer resized but not the channel views" issue is the best demonstration of what I'm trying to say. The channel views are stuck in the old sizes. That issue should be fixed when the channel resizing is implemented.
I hope i am clear and didn't muffle up anything.
So, looking at @zonkmachine's screenshot it looks like the mixer channels on the left still have the same-ish size as before but the effects rack on the right is quite large although it holds no effects. Do I understand correctly that this is the problem?
@zonkmachine, is it possible to make the mixer smaller in the scenario of the screenshot at the bottom in the comment https://github.com/LMMS/lmms/issues/7231#issuecomment-2081449070?
@zonkmachine, is it possible to make the mixer smaller in the scenario of the screenshot at the bottom in the comment #7231 (comment)?
Yes. It appears to provide space for a larger fader but you can grab the frame and make the mixer window the same size/layout that is shown in the first picture in the same comment.
Ok, due to the fact that the mixer channels stay the same and that the effects rack has to change its size it seems that the problem is caused by the initial height that's used by the effects rack. Seems that it has to be investigated how that height is determined.
@michaelgregorius just so you know, we are discussing on discord about starting the 1.3 release cycle. So I'm asking you to complete this fix and also finish the mixer strips to be resizeable too.
it seems that the problem is caused by the initial height that's used by the effects rack.
Seems related to #5851
@Rossmaxx, pull request #7293 adds support for resizable mixer strips.
If the problem described in this issue is caused by #5851 then it should be fixed in that context by the corresponding developer.
I cannot reproduce it on my machine with the current master (8636381). For me it starts with the mixer with the minimum vertical size. Does this only happen with specific projects?
And now I can no longer reproduce this. I backed 50 commits and tried it again but no luck. So, any ideas how to trigger it?
And now I can no longer reproduce this.
Might be a random glitch. Would be better to note if it comes up again.
But the main issue still stands. The mixer is still disproportionately large compared to 2 months ago - on my system and quite a few systems per reports on discord
@Rossmaxx, if I understand correctly, the problem that you are reporting is that everything above the channel selector is too large, right? Does the mixer in your screenshot already have the minimal size or is it possible to shrink it vertically?
Can you please also show how it looks with the send buttons being shown on some channels? You mentioned an alternative theme that you are using and I am wondering if the arrows for the send channels might be larger in that theme.
Otherwise, can you please check how it behaves with the changes of https://github.com/LMMS/lmms/pull/7293 applied?
The problem that you are reporting is that everything above the channel selector is too large, right?
Looks like it. I'll check and tell.
Does the mixer in your screenshot already have the minimal size or is it possible to shrink it vertically?
Haven't checked that before taking it. Will get back after checking.
You mentioned an alternative theme that you are using
It's nothing too much. I used an older version of default theme to demo #7202. Leaving those changes, it's the default.
There is, a custom theme image i got from discord (user jernemies).
We have to find out what's "wrong" in the send section of the mixers that are reported as problematic. In the default theme it looks as follows:
So they are rather compact. My assumption is that something must be taking space in these sections so that the top of the mixer strip appears larger when they are hidden like they normally are.
@michaelgregorius strange, this issue exists only on my windows partiton. Linux partition doesn't seem to be affected by this change.
Does the mixer in your screenshot already have the minimal size or is it possible to shrink it vertically?
Haven't checked that before taking it. Will get back after checking.
Nope. this is the least it can go. I'll try deleting lmmsrc.xml and look again
Seems like there has been a breakage with theming, deleting lmmsrc.xml (to reset to default) seems to fix this
@Rossmaxx, do you still have the old lmmsrc.xml? It would be interesting to take a diff with the newly created one so that we can get some ideas of what exactly might be causing this.
Does the problem reappear if you set the adjusted theme in the fresh configuration?
@Rossmaxx, do you still have the old lmmsrc.xml? It would be interesting to take a diff with the newly created one so that we can get some ideas of what exactly might be causing this.
I brought back the old lmmsrc.xml and set the current default, the issue is gone. Seems like something broke for older themes.
Might be a breakage due to change in qt properties between the theme and from before.