pyroomacoustics

pyroomacoustics copied to clipboard

Thanks for sending a pull request (PR), we really appreciate that! Before hitting the submit button, we'd be really glad if you could make sure all the following points have been cleared.

Please also refer to the doc on contributing for more details. Even if you can't check all the boxes below, do not hesitate to go ahead with the PR and ask for help there.

• [x] Are there docstrings ? Do they follow the numpydoc style ?
• [x] Have you run the tests by doing nosetests or py.test at the root of the repo ?
• [ ] Have you checked that the doc builds properly and that any new file has been added to the repo ? How to do that is covered in the documentation.
• [ ] Is there a unit test for the proposed code modification ? If the PR addresses an issue, the test should make sure the issue is fixed.
• [x] Last but not least, did you document the proposed change in the CHANGELOG file ? It should go under "Unreleased".

Happy PR :smiley:

Ran nosetests and I got the following error:

ERROR: Failure: ImportError (bad magic number in 'pyroomacoustics.c_package': b'\x03\xf3\r\n')

I like the idea of having this separate / more general RoomGenerator object, which could be an abstract class that takes as input a source generator and noise generator, with this example here being a subclass for ShoeBox rooms / the approach from this paper. (And another example/class can be made based off this paper).

I'll start off with creating the random sub-package and switching to argparse, and I'll also think more about how an API can be created with less assumptions.

I just saw your comment about bad magic number after running nosetests. This happen when the .pyc file is left over from a file that do not exist after switching branch. Here c_package relates to the C extension in master. You can manually delete the pyc files to get rid of the problem.

I just saw your comment about bad magic number after running nosetests. This happen when the .pyc file is left over from a file that do not exist after switching branch. Here c_package relates to the C extension in master. You can manually delete the pyc files to get rid of the problem.

Yes I found this solution online and deleting the pyc files was indeed the fix.