binary-compatibility-validator icon indicating copy to clipboard operation
binary-compatibility-validator copied to clipboard

Add Gradle version compatibility tests

Open fzhinkin opened this issue 1 year ago • 2 comments

Readme claims that BCV works with Gradle >= 6.0.

There are no tests checking that, so we need to add them.

fzhinkin avatar Apr 25 '24 08:04 fzhinkin

I tried to add such functional tests, but, for some reason, tests use project's Kotlin version (1.9.22) instead of the version specified in the test's build config. And 1.9.22 requires Gradle 6.8.3 or later.

fzhinkin avatar Apr 25 '24 08:04 fzhinkin

for some reason, tests use project's Kotlin version (1.9.22) instead of the version specified in the test's build config

This is probably because of withPluginClasspath()

https://github.com/Kotlin/binary-compatibility-validator/blob/3a7003363502236e64bbf044540e569b3eb808a4/src/functionalTest/kotlin/kotlinx/validation/api/TestDsl.kt#L40

aSemy avatar Apr 27 '24 11:04 aSemy

Added simple tests for minimal and major versions in https://github.com/Kotlin/binary-compatibility-validator/blob/18cd0df801cde896675b0a4b6fdf082e3eef33f7/src/functionalTest/kotlin/kotlinx/validation/test/GradleCompatibilityTest.kt#L15

shanshin avatar Aug 09 '24 15:08 shanshin