binary-compatibility-validator icon indicating copy to clipboard operation
binary-compatibility-validator copied to clipboard

BCV renders internal declarations public if their parameter types are relocated

Open sandwwraith opened this issue 3 years ago • 4 comments

There's this declaration in kotlinx-metadata: https://github.com/JetBrains/kotlin/blob/6abf14087c46e0b5c3015eec48b92162bc63c135/libraries/kotlinx-metadata/src/kotlinx/metadata/Flag.kt#L40

It has one public constructor and two internal. 0.12.0 introduces new JAR dump mode. In this mode, constructors are getting into public dump:

 	public fun <init> (Lkotlinx/metadata/internal/metadata/deserialization/Flags$BooleanFlagField;)V
	public fun <init> (Lkotlinx/metadata/internal/metadata/deserialization/Flags$FlagField;I)V

While in 0.11.0 in regular mode they weren't there

sandwwraith avatar Oct 24 '22 16:10 sandwwraith