github-integration-plugin icon indicating copy to clipboard operation
github-integration-plugin copied to clipboard

`Skip older PRs on first run` option does not persist

Open adamwong246 opened this issue 7 years ago • 5 comments

if you check this option, it will remain checked only for an amount of time. I'm not sure what unsets this, but I often check the configuration page to find it is now UN-checked.

Is this by design?

adamwong246 avatar Nov 15 '17 00:11 adamwong246

yes, to skip building PRs existed before, but i think that could be implemented with some time barrier

KostyaSha avatar Nov 15 '17 01:11 KostyaSha

our jenkins does not seem to persist the PRs either. This is the reason I'd like this option to stay fixed- so that I can refresh the PRs at any time without automatically triggering many jobs. But as it stands now, I must configure the job and re-check the Skip older PRs on first run, every time I wish refresh my PRs

adamwong246 avatar Nov 16 '17 00:11 adamwong246

This is really strange and major issue for us.

After running the trigger, this option gets unset. And because our PR's do not always persist, we need to re-run the trigger often.

how can I ensure that Skip older PRs on first run ALWAYS remains set?

adamwong246 avatar Dec 21 '17 20:12 adamwong246

how can I ensure that Skip older PRs on first run ALWAYS remains set?

I think it should be possible to place this field into local storage "PRRepository". It isn't touched by dsls so we can store this checkbox in it. Then it will be persisted, but DSL will be changing it all the time? Sounds like it wouldn't work. We can try to add something like "skip early than job creation" but there is no such date....

KostyaSha avatar Dec 21 '17 20:12 KostyaSha

Or "skip builds before date", where date will be clearly defined in DSL. That will exclude builds (before job created)...

KostyaSha avatar Dec 21 '17 20:12 KostyaSha