Power icon indicating copy to clipboard operation
Power copied to clipboard

Published 20 hours ago • verified publisher icon Kentzo

Functionality for remaining percentage (linux)

Open meepoSenpai opened this issue 9 years ago • 6 comments

This should add functionality to also get the remaining battery percentages of all batteries on linux

meepoSenpai avatar Jun 08 '16 15:06 meepoSenpai

@meepoSenpai We should add implementation for get_remaining_percentage for all other platforms. Even if the implementation simply raises NotImplementedError.

Kentzo avatar Jun 09 '16 20:06 Kentzo

It should suffice to raise a NotImplementedError in the Superclass, correct?

meepoSenpai avatar Jun 10 '16 08:06 meepoSenpai

Since it's an @abstractmethod it has to be implemented.

Kentzo avatar Jun 10 '16 16:06 Kentzo

get_remaining_percentage must be implemented for Windows or Darwin before this can be merged.

Kentzo avatar Oct 26 '16 07:10 Kentzo

I would say "Power" as a package is not complete until a few more things are being taken care of, such as get_remaining_percentage and get_time_remaining (which just works in an os-independent way).

kootenpv avatar Oct 28 '17 14:10 kootenpv

@kootenpv What is the difference between get_time_remaining_estimate and get_time_remaining?

Kentzo avatar Oct 30 '17 19:10 Kentzo