DataTable-AltEditor icon indicating copy to clipboard operation
DataTable-AltEditor copied to clipboard

Bootstrap 5 close buttons not closing form popup

Open erfg12 opened this issue 4 years ago • 3 comments

If you want the popups to close in Bootstrap 5, you need to change data-dismiss to data-bs-dismiss. There's 3 instances of this in the src/dataTables.altEditor.free.js file.

erfg12 avatar Jul 08 '21 18:07 erfg12

Maybe we can add both of them, so that it's backward compatible?

Il gio 8 lug 2021, 20:15 Jacob Fliss @.***> ha scritto:

If you want the popups to close in Bootstrap 5, you need to change data-dismiss to data-bs-dismiss. There's 3 instances of this in the src/dataTables.altEditor.free.js file.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/KasperOlesen/DataTable-AltEditor/issues/186, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACLII2B25NT6MEND3T2EFWTTWXTLNANCNFSM5ABH5OKQ .

luca-vercelli avatar Jul 08 '21 19:07 luca-vercelli

my fix

              var modal = `
                <div class="modal fade" id="${modal_id}" tabindex="-1" aria-labelledby="exampleModalLabel" aria-hidden="true">
                <div class="modal-dialog">
                  <div class="modal-content">
                    <div class="modal-header">
                      <h5 class="modal-title" id="exampleModalLabel">Modal title</h5>
                      <button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button>
                    </div>
                    <div class="modal-body">
                      <p></p>
                    </div>
                    <div class="modal-footer">
                    </div>
                  </div>
                </div>
              </div>`;

fix secondary button style, change: btn-default button secondary -> btn-secondary

full src: https://www.codepile.net/pile/bQL1JOdN work in progress... will be nice you help)

mmmcorpsvit avatar Jul 25 '21 01:07 mmmcorpsvit

@erfg12 Thanks.

deliciouslytyped avatar Jan 02 '24 15:01 deliciouslytyped