SparseArrays.jl icon indicating copy to clipboard operation
SparseArrays.jl copied to clipboard

Fix `show` of `QRSparseQ`

Open dkarrasch opened this issue 2 years ago • 1 comments

I don't know why this didn't come up earlier, but the size of the Q factor was missing. This now popped up in https://github.com/JuliaLang/julia/pull/46196. It can be removed once that one is merged, and then fall back to the generic show method defined there.

dkarrasch avatar Dec 03 '22 21:12 dkarrasch

Codecov Report

Merging #311 (f42551b) into main (16fc957) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
+ Coverage   93.62%   93.65%   +0.02%     
==========================================
  Files          12       12              
  Lines        7390     7390              
==========================================
+ Hits         6919     6921       +2     
+ Misses        471      469       -2     
Impacted Files Coverage Δ
src/solvers/spqr.jl 83.24% <100.00%> (+1.08%) :arrow_up:
src/sparsematrix.jl 95.39% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Dec 03 '22 22:12 codecov-commenter