SparseArrays.jl icon indicating copy to clipboard operation
SparseArrays.jl copied to clipboard

Published 20 hours ago • verified publisher icon JuliaSparse

Backports for release 1.9

Open dkarrasch opened this issue 2 years ago • 2 comments

dkarrasch avatar Nov 24 '22 11:11 dkarrasch

Codecov Report

Merging #300 (d32ecaf) into release-1.9 (311b4b4) will increase coverage by 0.13%. The diff coverage is 98.36%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@               Coverage Diff               @@
##           release-1.9     #300      +/-   ##
===============================================
+ Coverage        93.78%   93.91%   +0.13%     
===============================================
  Files               12       12              
  Lines             7334     7379      +45     
===============================================
+ Hits              6878     6930      +52     
+ Misses             456      449       -7
Impacted Files Coverage Δ
src/abstractsparse.jl 60.41% <ø> (+13.04%) :arrow_up:
src/solvers/cholmod.jl 90.83% <50.00%> (+0.17%) :arrow_up:
src/linalg.jl 95.65% <100.00%> (+0.15%) :arrow_up:
src/solvers/umfpack.jl 88.52% <100.00%> (ø)
src/sparsematrix.jl 95.54% <100.00%> (+0.17%) :arrow_up:
src/sparsevector.jl 95.03% <100.00%> (+0.01%) :arrow_up:
src/SparseArrays.jl 77.77% <0.00%> (-4.58%) :arrow_down:
... and 3 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Nov 24 '22 12:11 codecov-commenter

We currently don't have a pre-release of v1.9, so tests obviously fail. Once we have, then we should restrict testing to v1.9 and exclude nightly, to avoid visual clutter and test noise.

dkarrasch avatar Nov 24 '22 12:11 dkarrasch

Probably good to merge here and update in JuliaLang/julia sooner rather than later so we don't miss 1.9.

fredrikekre avatar Feb 16 '23 09:02 fredrikekre

Perhaps we should finalize #335, include it here and then go.

dkarrasch avatar Feb 16 '23 10:02 dkarrasch

Can this be updated, merged and bumped on backports-release-1.9?

KristofferC avatar Mar 06 '23 19:03 KristofferC

We don't squash this, right? Just create a merge commit. And how do we bump it over at backports-release-1.9? With the bot?

dkarrasch avatar Mar 07 '23 06:03 dkarrasch

Just wondering if this is going to be merged in 1.9-rcX.

1.9-rc2 was released yesterday. Previous Julia major releases usually had 3–4 release candidates, which means that we will probably have just one or two more release candidates for Julia 1.9. I think it will be nice to test these backports in release candidates before the official release of 1.9.

wsshin avatar Apr 05 '23 01:04 wsshin

Just create a merge commit.

Yes

With the bot?

Just do it manually. Update the hash in stdlib /SparseArrays.version.

Also, should probably remove nightly CI from this branch and make sure the doctests run on julia 1.9.

KristofferC avatar Apr 05 '23 09:04 KristofferC