ReinforcementLearning.jl icon indicating copy to clipboard operation
ReinforcementLearning.jl copied to clipboard

Devmode is not working

Open Mytolo opened this issue 2 years ago • 3 comments

I recognized lately that the compat version in the Project.toml files are not suited in order to call activate_devmode!() from src/devmode.jl. In my opinion it may be beneficial for developers trying to get into contribution to have a Project.toml.dev or something like this in order to get the Project working. That way, julia handles all dependencies on its own and everybody has the same library state w.r.t the repository state.

What do you think about this?

Mytolo avatar Jul 03 '23 09:07 Mytolo

Doesn't it devs the local packages and ignores project.toml ? If you use the main branch.

HenriDeh avatar Jul 06 '23 08:07 HenriDeh

Well it does not ignore the Project.toml. In my case it results in package resolve issues and i have to adjust the compat entries to the version in the repo.

Here is a screenshot of the resolution error when cloning the repo and invoking activate_devmode!()

image

Mytolo avatar Jul 06 '23 09:07 Mytolo

@Mytolo You need to dev each sub-package individually, without importing the umbrella package.

Personally, I would remove the top-level activate_devmode! function.

joelreymont avatar Mar 06 '24 19:03 joelreymont