RegistryCI.jl icon indicating copy to clipboard operation
RegistryCI.jl copied to clipboard

Published 20 hours ago • verified publisher icon JuliaRegistries

Remove SimpleMock and only use BrokenRecord?

Open DilumAluthge opened this issue 4 years ago • 1 comments

So, currently, our test dependencies include the following:

  1. BrokenRecord.jl - does not use Cassette
  2. SimpleMock.jl - uses Cassette

Out of curiosity, would it be feasible to remove SimpleMock and only use BrokenRecord? I only ask because Cassette can be inconvenient to work with sometime. (E.g. currently we skip the Cassette-based steps on Julia nightly on CI.)

So I guess the question is:

  1. What tests currently use SimpleMock?
  2. Can all of those tests be migrated to use BrokenRecord only?

cc: @christopher-dG

DilumAluthge avatar Dec 08 '20 01:12 DilumAluthge

I think most of its uses can be replaced, but not trivially. There is one instance of mocking now where that test would just need to be removed.

christopher-dG avatar Dec 08 '20 03:12 christopher-dG