General

General copied to clipboard

• Registering package: Skipper
• Repository: https://gitlab.com/aplavin/Skipper.jl
• Created by: https://gitlab.com/aplavin
• Version: v0.1.1
• Commit: 010000030bc4c0e9ff6b32751dc69ca34b70483f
• Git reference: HEAD

Your new package pull request does not meet the guidelines for auto-merging. Please make sure that you have read the General registry README and the AutoMerge guidelines. The following guidelines were not met:

• Package name similar to 1 existing package.
  1. Similar to Clipper. Damerau-Levenshtein distance 2 is at or below cutoff of 2.

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

After you have fixed the AutoMerge issues, simple retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number).

If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged.

Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1

---

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@aplavin isn't https://gitlab.com/aplavin/Skipper.jl/-/blob/010000030bc4c0e9ff6b32751dc69ca34b70483f/src/Skipper.jl#L11 type-piracy?

@giordano yes, that's indeed the case. Never heard of Base.skip before, and had to use Base.skip(...) = ... instead of just skip(...) = ... after finding that it exists.

name similarity looks totally fine for me, please merge... 3 days have passed

Name is fine, but I'm concerned about the type piracy. Can't you just define a function Skipper.skip without importing Base.skip?

Maybe I'm somewhat out of the loop, but don't see major issues with piracy turning a methoderror into working code. Clearly, there are packages doing these things already. Different story with turning "working" into "working in a different way", of course.

If I define Skipper.skip, then it cannot be used as using Skipper; skip(...) (right?).

Ok, well, we'll see how this goes with regards to possible invalidations

Thanks! I'm still not very familiar with this (piracy/invalidations/...) part of julia development, so may be mistaken that the current approach is optimal...