New package: gRPCClient2 v1.0.0
- Registering package: gRPCClient2
- Repository: https://github.com/csvance/gRPCClient2.jl
- Created by: @csvance
- Version: v1.0.0
- Commit: 305930684de48843847bc2a5a53dbba5e3aff7f6
- Reviewed by: @csvance
- Reference: https://github.com/csvance/gRPCClient2.jl/commit/305930684de48843847bc2a5a53dbba5e3aff7f6#commitcomment-170556715
- Description: Production Grade gRPC Client for Julia
Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.
1. New package registration
Please make sure that you have read the package naming guidelines.
2. AutoMerge Guidelines which are not met ❌
- Name does not meet all of the following: starts with an upper-case letter, ASCII alphanumerics only, not all letters are upper-case.
- Package name similar to 1 existing package.
- Similar to gRPCClient. Damerau-Levenshtein distance 1 is at or below cutoff of 2. Damerau-Levenshtein distance 1 between lowercased names is at or below cutoff of 1.
3. Needs action: here's what to do next
- Please try to update your package to conform to these guidelines. The General registry's README has an FAQ that can help figure out how to do so.
- After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your
Project.tomlfile (unless the AutoMerge issue is that you skipped a version number).
If you need help fixing the AutoMerge issues, or want your pull request to be manually merged instead, please post a comment explaining what you need help with or why you would like this pull request to be manually merged. Then, send a message to the #pkg-registration channel in the public Julia Slack for better visibility.
4. To pause or stop registration
If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.
Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.
There are two things I should address right off the bat.
Package Name
Obviously just adding a 2 to an existing package name isn't ideal. I wrote this package after I had major issues trying to use gRPCClient.jl including deadlocks, segfaults, and general performance problems. The package does not appear to be actively maintained. I tried to fix the issues with gRPCClient.jl but decided it would be faster to just rewrite the entire thing.
Needing a patch to ProtoBuf.jl for code generation
https://github.com/JuliaIO/ProtoBuf.jl/pull/283
A simple patch is required to ProtoBuf.jl in order to enable code generation support. The patch is not needed to actually make gRPC requests.
I have not been able to get in contact with the maintainers after a month. Of course this is open source and people can be busy, but I thought maybe getting the package to this stage might be able to help trigger a conversation to push this through.
“starts with an upper-case letter” is a hard rule, notwithstanding a handful of existing packages that slipped through before this was enforced.
As mentioned on Slack, improving the existing package would really be the better way to go here. We can surely find a way to make that work.
“starts with an upper-case letter” is a hard rule, notwithstanding a handful of existing packages that slipped through before this was enforced.
As suggested on Slack by Ronny, we could work around that by doing something similar to ProtoBuf 1.0 release where the rewrite inherited the old package name despite being completely breaking. I did reach out to one of the maintainers of gRPCClient.jl about this around a month ago but didn't hear back. Being new to the Julia community, one of the main reasons I triggered the registration process was to hopefully be able to work through this as I don't really know who I should talk to, what their bandwidth is, etc. The last thing I want to do is cause undue burden on anyone volunteering their time in an open source project.
That is a bit of an unusual way to do so, but sure as a new person to these processes, I do agree that this is maybe not so clear. Let's try to reach out to the original developers then
That is a bit of an unusual way to do so, but sure as a new person to these processes, I do agree that this is maybe not so clear. Let's try to reach out to the original developers then
If backwards compatibility is a major concern, I could implement a wrapper around the new public interface style which could make the transition more seamless. The issue is its far more difficult to migrate from 0.X ProtoBuf to 1.X, which is also required.
If you do a breaking release of a package it is up to you how kind you want to be with users of the package. A wrapper is not necessary, I think. A new package – like this PR – is definitely not necessary ;)
A new package – like this PR – is definitely not necessary ;)
Point taken! I appreciate you taking the time to help me out despite my obvious inexperience and reaching out to people who can help me get this across the finish line. We can consider this pull request closed.
This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock]
This pull request has been inactive for more than 30 days and has automatically been closed. Feel free to register your package or version again once you fix the AutoMerge issues. [noblock]