BinaryBuilder.jl

BinaryBuilder.jl copied to clipboard

This PR fixes #1227.

It doesn't look like this worked very well

I tested locally and found that even if I commented out my modifications, the test suite still failed.

Linux x86_64 {cxxstring_abi=cxx11, julia_version=1.8.1, libc=glibc, libgfortran_version=5.0.0, libstdcxx_version=3.4.29}: Error During Test at /home/ubuntu/.julia/dev/BinaryBuilder/test/building.jl:105
  Got exception outside of a @test
  DimensionMismatch: mismatch in dimension 1 (expected 1 got 5)
  Stacktrace:
    [1] _cs
      @ ./abstractarray.jl:1717 [inlined]
    [2] _cshp
      @ ./abstractarray.jl:1713 [inlined]
    [3] _cat_size_shape
      @ ./abstractarray.jl:1693 [inlined]
    [4] cat_size_shape(dims::Tuple{Bool, Bool}, X::String, tail::Vector{SubString{String}})
      @ Base ./abstractarray.jl:1691
    [5] _cat_t(::Val{2}, ::Type{AbstractString}, ::String, ::Vararg{Any})
      @ Base ./abstractarray.jl:1732
    [6] _cat(::Val{2}, ::String, ::Vararg{Any})
      @ Base ./abstractarray.jl:1728
    [7] #cat#155
      @ ./abstractarray.jl:1916 [inlined]
    [8] hcat(::String, ::Vector{SubString{String}})
      @ Base ./abstractarray.jl:1878
    [9] with_libgfortran(f::Function)
      @ Main ~/.julia/dev/BinaryBuilder/test/runtests.jl:23
   [10] (::var"#25#27"{Platform, Vector{Platform}})(build_path::String)
      @ Main ~/.julia/dev/BinaryBuilder/test/building.jl:172
   [11] mktempdir(fn::var"#25#27"{Platform, Vector{Platform}}, parent::String; prefix::String)
      @ Base.Filesystem ./file.jl:764
   [12] mktempdir(fn::Function, parent::String) (repeats 2 times)
      @ Base.Filesystem ./file.jl:760
   [13] macro expansion
      @ ~/.julia/dev/BinaryBuilder/test/building.jl:108 [inlined]
   [14] macro expansion
      @ ~/packages/julias/julia-1.8/share/julia/stdlib/v1.8/Test/src/Test.jl:1433 [inlined]
   [15] macro expansion
      @ ~/.julia/dev/BinaryBuilder/test/building.jl:105 [inlined]
   [16] macro expansion
      @ ~/packages/julias/julia-1.8/share/julia/stdlib/v1.8/Test/src/Test.jl:1357 [inlined]
   [17] top-level scope
      @ ~/.julia/dev/BinaryBuilder/test/building.jl:105
   [18] include(fname::String)
      @ Base.MainInclude ./client.jl:476
   [19] top-level scope
      @ ~/.julia/dev/BinaryBuilder/test/runtests.jl:70
   [20] include(fname::String)
      @ Base.MainInclude ./client.jl:476
   [21] top-level scope
      @ none:6
   [22] eval
      @ ./boot.jl:368 [inlined]
   [23] exec_options(opts::Base.JLOptions)
      @ Base ./client.jl:276
   [24] _start()
      @ Base ./client.jl:522
Test Summary:                                                                                                              | Pass  Error  Total   Time
Shard testsuites                                                                                                           |    4      1      5  16.0s
  Linux x86_64 {cxxstring_abi=cxx11, julia_version=1.8.1, libc=glibc, libgfortran_version=5.0.0, libstdcxx_version=3.4.29} |    4      1      5  15.8s
ERROR: LoadError: Some tests did not pass: 4 passed, 0 failed, 1 errored, 0 broken.
in expression starting at /home/ubuntu/.julia/dev/BinaryBuilder/test/building.jl:104
in expression starting at /home/ubuntu/.julia/dev/BinaryBuilder/test/runtests.jl:70
ERROR: Package BinaryBuilder errored during testing

That test has nothing to do with the wizard though. Comment out https://github.com/JuliaPackaging/BinaryBuilder.jl/blob/c3ab9105f9f4787eda1deee5586a58738d4c9f40/test/runtests.jl#L69-L72 to run only the wizard tests.